Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

refactor(position): Remove deprecated body scrollTop and scrollLeft #1677

Closed
wants to merge 1 commit into from
Closed

refactor(position): Remove deprecated body scrollTop and scrollLeft #1677

wants to merge 1 commit into from

Conversation

mvhecke
Copy link
Contributor

@mvhecke mvhecke commented Jan 26, 2014

Removes the use of deprecated variables in strict mode which caused the following errors(#1658).

body.scrollTop is deprecated in strict mode. Please use 'documentElement.scrollTop' if in strict mode and 'body.scrollTop' only if in quirks mode.
body.scrollLeft is deprecated in strict mode. Please use 'documentElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode.

@mvhecke
Copy link
Contributor Author

mvhecke commented Jan 26, 2014

It does pass the build test, I'm however not sure about the behavior in all supported browsers.

@pkozlowski-opensource
Copy link
Member

@Gamemaniak you can use this little test file:
https://github.com/angular-ui/bootstrap/blob/master/src/position/test/test.html

to manually / visually check if things are allright in all the supported browsers.

@mvhecke
Copy link
Contributor Author

mvhecke commented Jan 26, 2014

@pkozlowski-opensource I'll check it out tomorrow.

  • Chrome 32
  • Firefox 26
  • Opera 12
  • Safari
  • IE 11
  • IE 10
  • IE 9

Sorry, something went wrong.

@mvhecke
Copy link
Contributor Author

mvhecke commented Jan 27, 2014

It'll be a day later, haven't got enough time today.

@mvhecke
Copy link
Contributor Author

mvhecke commented Jan 28, 2014

@pkozlowski-opensource I've tested it and it seems fine, although I tested it in IE11 with developer mode for IE9 and IE10 so I'm not sure if that representative.

@bekos
Copy link
Contributor

bekos commented Jan 28, 2014

@Gamemaniak You can try this: http://www.modern.ie/ :D

@ajoslin
Copy link
Contributor

ajoslin commented Jan 29, 2014

@Gamemaniak I accidentally deleted your latest comment with the delete button - sorry :) You might want to repost it

@mvhecke
Copy link
Contributor Author

mvhecke commented Jan 29, 2014

No problem @ajoslin. The only browser that was giving me strange behavior was IE10, but that was due to opening the developer tools which triggered IE7 mode. But positioning seems fine in all the tested browsers with this fix.

@pkozlowski-opensource
Copy link
Member

Cool, I think this one is good to go in. In fact those deprecated calls were introduced for IE8 in 9aecd4e. But since we don't support IE8 we don't care, I guess.

@pkozlowski-opensource
Copy link
Member

Thnx @Gamemaniak !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants