drop max voice count to 20

32 is an overkill even for *dreaming* #144
anokta · Nov 10, 2024 · dab112c · dab112c
1 parent 6f967c3
commit dab112c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/platforms/unity/Assets/BarelyMusician/Scripts/Instrument.cs b/platforms/unity/Assets/BarelyMusician/Scripts/Instrument.cs
@@ -131,7 +131,7 @@ public bool HasChanged {
     public double Gain = 1.0;
 
     /// Number of voices.
-    [Range(1, 32)]
+    [Range(1, 20)]
     public int VoiceCount = 8;
 
     /// Oscillator shape.

diff --git a/src/internal/instrument.h b/src/internal/instrument.h
@@ -171,7 +171,7 @@ class Instrument {
   // Array of controls.
   ControlArray controls_ = {
       Control(1.0, 0.0, 1.0),                                                // kGain
-      Control(8, 1, 32),                                                     // kVoiceCount
+      Control(8, 1, 20),                                                     // kVoiceCount
       Control(0, 0, static_cast<int>(BarelyOscillatorShape_kCount) - 1),     // kOscillatorShape
       Control(0, 0, static_cast<int>(BarelySamplePlaybackMode_kCount) - 1),  // kSamplePlaybackMode
       Control(0.0, 0.0, 60.0),                                               // kAttack

diff --git a/src/internal/instrument_processor.cpp b/src/internal/instrument_processor.cpp
@@ -15,7 +15,7 @@ namespace barely::internal {
 namespace {
 
 // Maximum number of voices allowed to be set.
-constexpr int kMaxVoiceCount = 32;
+constexpr int kMaxVoiceCount = 20;
 
 // Returns the frequency ratio of a given `pitch`.
 double FrequencyRatioFromPitch(double pitch) { return std::pow(2.0, pitch); }