(example) Patch some crates that we have forked at the workspace level for namada v0.7.1 #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #527
This PR changes
tendermint-rs
,ibc-rs
andtower-abci
forks that we depend on to be patched in the workspaceCargo.toml
, rather than pulled in directly via git in individual crateCargo.toml
s. Feature flags we are using stay specified in individual crateCargo.toml
s. We are already following this sort of pattern for ourborsh
fork.Also in tandem with this PR, our
ibc-rs
andtower-abci
forks should be updated to do something similar.ibc-rs - heliaxdev/ibc-rs#3
tower-abci - heliaxdev/tower-abci#2
Specifically, they shouldn't depend on our
tendermint-rs
fork directly via git but should instead use a[patch.crates-io]
entry. This means when we patchtendermint-rs
innamada
, e.g. changing therev
to something different, the patch will propagate toibc-rs
andtower-abci
without us having to go and update the hardcodedrev
in those forks as well.