[Enabler][Zos Job Submit]Update undocumented argument and import exception #1091
Conversation
AndreMarcel99
requested review from
fernandofloresg,
ddimatos,
richp405,
ketankelkar and
rexemin
and removed request for
fernandofloresg and
ddimatos
plugins/modules/zos_job_submit.py
Outdated
| @@ -902,7 +899,7 @@ def run_module(): | |||
| from_encoding = parsed_args.get("from_encoding") | |||
| to_encoding = parsed_args.get("to_encoding") | |||
| # temporary file names for copied files when user sets location to LOCAL | |||
| temp_file = parsed_args.get("temp_file") | |||
| temp_file = parsed_args.get("src") | |||
There was a problem hiding this comment.
I would suggest doing this change instead :
| temp_file = parsed_args.get("src") | |
| if location == "LOCAL": | |
| temp_file = parsed_args.get("src") |
That way temp_file is indeed a temporary file on the remote and we don't need to worry on the location conditions in the future, if temp_file is None we know we don't have to remove anything.
plugins/modules/zos_job_submit.py
Outdated
| @@ -1039,7 +1036,7 @@ def run_module(): | |||
| module.exit_json(**result) | |||
|
|
|||
| finally: | |||
| if temp_file: | |||
| if location != "DATA_SET" and location != "USS": | |||
There was a problem hiding this comment.
| if location != "DATA_SET" and location != "USS": | |
| if temp_file: |
I suggest keeping it this way bc that will help us avoid having to check for state and just remove it if it exists.
There was a problem hiding this comment.
It generates a error if the local file is named as a dataset (USER.LOCAL) then the file /user.local will fail that verification
There was a problem hiding this comment.
I'm sorry I don't get how that relates to this code suggestion, could you explain?
AndreMarcel99
changed the title
|
Pipeline for all except zos_copy 
|
|
Pipeline zos_copy |
|
I made some extra changes and I'm waiting for the pipeline to finish. |
|
|
|
In case anyone wonders why |
AndreMarcel99
deleted the
enable/997-999/update-sanity-test-ignore-9-11
branch
SUMMARY
Update temp_path and how to import exceptions.
Fiexes #997 #998 #999
ISSUE TYPE
ADDITIONAL INFORMATION
Remove tmp path from options and only work with source as name of tmp file, because it was undocumented argument for ansible and could be any name, also only in case is local make the tmp file, so didn't expect a dataset or file with the same name on the system. Also make a implementation of imports of exceptions by using new implementation to avoid losing context when an import fails.
Pipeline Without Zos_copy
Pipeline with zos_copy