Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.9.0] [backport] [Bug] [module_util/data_set] Remove leading '-' chars from parsed volume serial strings #1247

Merged

Conversation

ketankelkar
Copy link
Collaborator

@ketankelkar ketankelkar commented Feb 22, 2024

backports a fix for a minor parsing issue in the data_set_cataloged_volume_list() function where the contents of LISTCAT are parsed for volume serials. The issue was the volser str was assumed to be exactly 6 chars, and if it wasn't, the requisite number of -s where prepended.

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request

… -- same logic introduced to v1.10.0-beta.1 in pr #1242

Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com>
@ketankelkar ketankelkar self-assigned this Feb 22, 2024
@ketankelkar
Copy link
Collaborator Author

passing regression for zos_data_set functional tests only. keep an eye out for full regression coming shortly:
image
image

Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com>
Copy link
Collaborator

@rexemin rexemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this bug while also improving the readability of this function

Copy link
Collaborator

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requested a change in the changelog fragment, other looks good. Glad you've found the issue root cause and fixed it 😄

Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com>
@ketankelkar
Copy link
Collaborator Author

ketankelkar commented Feb 28, 2024

The test cases identified by the dependency finder were broken up into a number of chunks and tested across the span of multiple days and multiple zvms:

image

tests/functional/modules/test_zos_fetch_func.py 
tests/functional/modules/test_zos_unarchive_func.py 
tests/unit/test_zos_operator_unit.py 
tests/unit/test_zos_backup_restore_unit.py 
tests/functional/modules/test_zos_backup_restore.py 
tests/functional/modules/test_zos_tso_command_func.py 
tests/functional/modules/test_zos_data_set_func.py 

image

tests/functional/modules/test_zos_copy_func.py 

image

tests/functional/modules/test_zos_job_query_func.py 
tests/functional/modules/test_zos_script_func.py 
tests/functional/modules/test_zos_mvs_raw_func.py 
tests/functional/modules/test_zos_archive_func.py 
tests/unit/test_zos_mvs_raw_unit.py 
tests/functional/modules/test_zos_blockinfile_func.py 
tests/functional/modules/test_zos_find_func.py 

image

tests/unit/test_zos_operator_action_query_unit.py 
tests/functional/modules/test_zos_operator_action_query_func.py 
tests/functional/modules/test_zos_job_submit_func.py 

image

tests/functional/modules/test_zos_apf_func.py 

image

tests/functional/modules/test_zos_mount_func.py 
tests/functional/modules/test_zos_encode_func.py 
tests/functional/modules/test_zos_job_output_func.py 
tests/functional/modules/test_zos_volume_init_func.py 
tests/functional/modules/test_zos_operator_func.py 
tests/functional/modules/test_zos_lineinfile_func.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants