Fail if old ANSIBLE_COLLECTIONS_PATHS is detected #449
+44
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
major/colpath
branch
from
ed31681 to
beadea6
Compare
Make presence of ANSIBLE_COLLECTIONS_PATHS variable a runtime error, asking user to either remove it or replace it with ANSIBLE_COLLECTION_PATHS. Removes config.ansible_collections_path method because is no longer needed and it was not used by ansible-lint nor molecule.
ssbarnea
force-pushed
the
major/colpath
branch
from
beadea6 to
8bc707b
Compare
cidrblock
approved these changes
Jan 22, 2025
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Jan 22, 2025
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Jan 22, 2025
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
Jan 22, 2025
ssbarnea
added a commit
that referenced
this pull request
Jan 23, 2025
ssbarnea
added a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make presence of outdated
ANSIBLE_COLLECTIONS_PATHS(double plural) variable a runtime error, asking user to either remove it or replace it withANSIBLE_COLLECTION_PATHS.Removes config.ansible_collections_path method because is no longer needed and it was not used by ansible-lint nor molecule.
This will reduce code complexity in our tools and speed-up migration of outdated configurations. While ansible-core still recognize old one, development tools will no
longer tolerate its presence, as this caused various hard to debug bugs for our users.
Reference: https://docs.ansible.com/ansible/latest/reference_appendices/config.html#collections-paths