Fix collection detail global css (#4143)

* Collection dependencies - reduce custom css, add missing space before helpertext

moving CollectionUsedbyDependenciesList outside the pf-c-content section removes the need for custom pagination styling
(we'll now get 2 different empty states for deps & rdeps when both are missing)

No-Issue

* Collection docs - rename css classes to hub-docs-{container,content,main,sidebar}, remove global toolbar margin

affects the new insights breadcrumbs, this fixed it

* hub-nav-title

* duplicate/unused legacy role scss

* hub-header-bordered: replace old header class

* header-bottom -> hub-header-bottom

* merge hub-toolbar and hub-list-toolbar css

now that `.pf-c-toolbar__group { margin-left: 16px }` is limite to `.hub-docs-sidebar`, changing the left padding is no longer needed .. which makes hub-toolbar and hub-list-toolbar identical, merging

* approvals: use ToolbarContent, add missing niceNames

* hub-toolbar, hub-toolbar-left - unify from .toolbar, .hub-toolbar-wrapper

Author: himdel

src/components/collection-dependencies-list/collection-dependencies-list.tsx

@@ -1,5 +1,5 @@
 import { t } from '@lingui/macro';
-import { List, ListItem, ListVariant } from '@patternfly/react-core';
+import { List, ListItem } from '@patternfly/react-core';
 import React from 'react';
 import { Link } from 'react-router-dom';
 import { CollectionVersion, CollectionVersionSearch } from 'src/api';
@@ -29,7 +29,7 @@ export const CollectionDependenciesList = ({
   }
 
   return (
-    <List variant={ListVariant.inline} className='hub-c-list-dependencies'>
+    <List className='hub-c-list-dependencies'>
       {dependencies_repos.map((dependency, i) =>
         listDep(dependency, i, dependencies),
       )}
@@ -50,7 +50,7 @@ const listDep = (dependency, i, dependencies) => {
   } else {
     return (
       <ListItem key={i} style={{ marginRight: '70px' }}>
-        {fqn}: {version_range}
+        {fqn}: {version_range}{' '}
         <HelperText
           content={t`No version of ${fqn} exists that matches ${version_range}.`}
         />

src/components/collection-list/collection-filter.scss

@@ -1,12 +1,4 @@
-.hub-toolbar-wrapper {
-  .toolbar {
-    display: flex;
-    justify-content: space-between;
-    align-items: center;
-
-    .hub-pagination-container {
-      display: flex;
-      align-items: center;
-    }
-  }
+.hub-pagination-container {
+  display: flex;
+  align-items: center;
 }