Fix collection detail global css #4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backport-4.7
himdel
force-pushed
the
collection-detail-global-css
branch
from
cf34ed1 to
05a3593
Compare
… helpertext moving CollectionUsedbyDependenciesList outside the pf-c-content section removes the need for custom pagination styling (we'll now get 2 different empty states for deps & rdeps when both are missing) No-Issue
…ain,sidebar}, remove global toolbar margin affects the new insights breadcrumbs, this fixed it
himdel
force-pushed
the
collection-detail-global-css
branch
from
32a308d to
e6367fa
Compare
now that `.pf-c-toolbar__group { margin-left: 16px }` is limite to `.hub-docs-sidebar`, changing the left padding is no longer needed .. which makes hub-toolbar and hub-list-toolbar identical, merging
himdel
force-pushed
the
collection-detail-global-css
branch
from
c4435f0 to
0d6f5d2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Aug 27, 2023
* Collection dependencies - reduce custom css, add missing space before helpertext
moving CollectionUsedbyDependenciesList outside the pf-c-content section removes the need for custom pagination styling
(we'll now get 2 different empty states for deps & rdeps when both are missing)
No-Issue
* Collection docs - rename css classes to hub-docs-{container,content,main,sidebar}, remove global toolbar margin
affects the new insights breadcrumbs, this fixed it
* hub-nav-title
* duplicate/unused legacy role scss
* hub-header-bordered: replace old header class
* header-bottom -> hub-header-bottom
* merge hub-toolbar and hub-list-toolbar css
now that `.pf-c-toolbar__group { margin-left: 16px }` is limite to `.hub-docs-sidebar`, changing the left padding is no longer needed .. which makes hub-toolbar and hub-list-toolbar identical, merging
* approvals: use ToolbarContent, add missing niceNames
* hub-toolbar, hub-toolbar-left - unify from .toolbar, .hub-toolbar-wrapper
(cherry picked from commit b051f84)
himdel
added a commit
that referenced
this pull request
Aug 28, 2023
* Collection dependencies - reduce custom css, add missing space before helpertext
moving CollectionUsedbyDependenciesList outside the pf-c-content section removes the need for custom pagination styling
(we'll now get 2 different empty states for deps & rdeps when both are missing)
No-Issue
* Collection docs - rename css classes to hub-docs-{container,content,main,sidebar}, remove global toolbar margin
affects the new insights breadcrumbs, this fixed it
* hub-nav-title
* duplicate/unused legacy role scss
* hub-header-bordered: replace old header class
* header-bottom -> hub-header-bottom
* merge hub-toolbar and hub-list-toolbar css
now that `.pf-c-toolbar__group { margin-left: 16px }` is limite to `.hub-docs-sidebar`, changing the left padding is no longer needed .. which makes hub-toolbar and hub-list-toolbar identical, merging
* approvals: use ToolbarContent, add missing niceNames
* hub-toolbar, hub-toolbar-left - unify from .toolbar, .hub-toolbar-wrapper
(cherry picked from commit b051f84)
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove/refactor any global css that would affect patternfly,
clean up some custom css in the collection detail area.
Mostly because insights breadcrumb toolbar has an unexpected 16px margin when opening collection detail, so fixing that.
Also unifies toolbar css on just
hub-toolbar(instead oftoolbar,hub-toolbar,hub-list-toolbarandhub-toolbar-wrapper) andhub-toolbar-left(modifier for collections, namespaces).Buttons after toolbar filters are now slightly closer, they no longer get an extra 16px margin meant only for docs filter.