screenshot tests: add more screens, blackout time, enable legacy #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backport-4.7
|
(merging and cleaning the cache, so the cron action can recreate the new cache for #4143) |
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #4146 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 26, 2023
* screenshot tests: add more screens, blackout time, enable legacy No-Issue * lint * rename screenshots.js to screenshots-main when cached, fix paths for extra suite name (cherry picked from commit 9b0eca6)
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change screenshot folder from
cypress/screenshots/test_name.js/tocypress/screenshots/test_suite_name/test_name.js/(test_suite meaning all thecypress/e2e/subdirs used in test matrix).Wrap our
DateComponentin a<time>element, following https://microformats.org/wiki/datetime-design-pattern,blackout
timeelements in non-failure cypress screenshots - we can test more screens.Enable legacy roles for the screenshots run, allowing us to test those screens.