Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new permisssions #1002

Merged
merged 8 commits into from
Oct 8, 2021
Merged

Conversation

ZitaNemeckova
Copy link
Member

@ZitaNemeckova ZitaNemeckova commented Sep 29, 2021

Fixes https://issues.redhat.com/browse/AAH-956

Depends on ansible/galaxy_ng#1003 (merged)

TODO:

  • Delete containers: pulp_container.delete_containerrepository

Screenshot 2021-10-05 at 11 13 29

  • Delete collections: ansible.delete_collection

Screenshot 2021-10-05 at 11 16 24

  • Delete namespace: galaxy.delete_namespace

Screenshot 2021-09-29 at 13 53 57

  • Delete registry: galaxy.delete_containerregistryremote

Screenshot 2021-09-29 at 13 00 00

  • Create Registry: galaxy.add_containerregistryremote

Screenshot 2021-09-29 at 12 50 11

  • Change registry: galaxy.change_containerregistryremote

Screenshot 2021-09-29 at 12 59 27

@ZitaNemeckova ZitaNemeckova added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Sep 29, 2021
@ZitaNemeckova ZitaNemeckova requested a review from himdel October 5, 2021 09:17
@himdel
Copy link
Collaborator

himdel commented Oct 5, 2021

The changes look good, but I don't think add_remote, change_remote and delete_remote are the right permissions for container registries, given that we also have add_containerregistry, change_containerregistry and delete_containerregistry (from ansible/galaxy_ng#1003)

@ZitaNemeckova ZitaNemeckova requested a review from himdel October 7, 2021 07:14
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
verified this stops an unpriviledged user from adding/changing/removing these registries 👍
and removing container repositories 👍

@ZitaNemeckova ZitaNemeckova merged commit fadfa18 into ansible:master Oct 8, 2021
@patchback
Copy link

patchback bot commented Oct 8, 2021

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/fadfa1856e8fe7010343612ffd03d15ae6f9858e/pr-1002

Backported as #1055

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 8, 2021
* Add new permisssions to Remote list

* Add permission check to Delete Namespace button

* Add missing permissions to API user response type

* Move dropdown items to a variable and hide dropdown if no items

* Fix wrong cndition

* Add delete_collection permission

* Add delete_containerrepository permission

* Fix the permission to coorrect one

(cherry picked from commit fadfa18)
himdel pushed a commit that referenced this pull request Oct 8, 2021
* Add new permisssions to Remote list

* Add permission check to Delete Namespace button

* Add missing permissions to API user response type

* Move dropdown items to a variable and hide dropdown if no items

* Fix wrong cndition

* Add delete_collection permission

* Add delete_containerrepository permission

* Fix the permission to coorrect one

(cherry picked from commit fadfa18)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 8, 2021
@himdel himdel mentioned this pull request Oct 15, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants