-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new permisssions #1002
Add new permisssions #1002
Conversation
e9143d2
to
3206203
Compare
The changes look good, but I don't think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
verified this stops an unpriviledged user from adding/changing/removing these registries 👍
and removing container repositories 👍
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1055 🤖 @patchback |
* Add new permisssions to Remote list * Add permission check to Delete Namespace button * Add missing permissions to API user response type * Move dropdown items to a variable and hide dropdown if no items * Fix wrong cndition * Add delete_collection permission * Add delete_containerrepository permission * Fix the permission to coorrect one (cherry picked from commit fadfa18)
* Add new permisssions to Remote list * Add permission check to Delete Namespace button * Add missing permissions to API user response type * Move dropdown items to a variable and hide dropdown if no items * Fix wrong cndition * Add delete_collection permission * Add delete_containerrepository permission * Fix the permission to coorrect one (cherry picked from commit fadfa18) Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
Fixes https://issues.redhat.com/browse/AAH-956
Depends on ansible/galaxy_ng#1003 (merged)
TODO: