Set a default value of 10 for remote download concurrency #1034
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
reviewed
Oct 4, 2021
jctanner
changed the title
himdel
approved these changes
Oct 5, 2021
himdel
requested changes
Oct 5, 2021
himdel
reviewed
Oct 5, 2021
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1042 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
* Set a default value of 1 for remote download concurrency * bump default to 10 per awcrosby * prettier * skip setting default if registry type * prettier * use updateRemote instead (cherry picked from commit 71d069d)
himdel
pushed a commit
that referenced
this pull request
Oct 6, 2021
) * Set a default value of 1 for remote download concurrency * bump default to 10 per awcrosby * prettier * skip setting default if registry type * prettier * use updateRemote instead (cherry picked from commit 71d069d) Co-authored-by: jctanner <tanner.jc@gmail.com>
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit form for a remote repository has a null value for concurrency even though the validation requires an integer greater than 1. The user does not have any context clues that the value is invalid until they try typing something into the field. Setting a
110 by default helps eliminate headache.This will be one option to fix this issue, and a second involving a schema migration will follow.Links [Optional]
Steps for Testing/QA [Optional]