Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests to remote registries form #1112

Merged
merged 4 commits into from
Nov 4, 2021
Merged

add tests to remote registries form #1112

merged 4 commits into from
Nov 4, 2021

Conversation

ShaiahWren
Copy link
Contributor

Hello :)

Issue: https://issues.redhat.com/browse/AAH-999

I added username and password to the 'add remote registries form.'
Hopefully this is what you had in mind, lmk :)
Are there any other fields you would like me to test?

@ShaiahWren ShaiahWren requested a review from himdel October 18, 2021 21:08
@himdel
Copy link
Collaborator

himdel commented Oct 19, 2021 •
edited
Loading

I think we should test all of them, because we also want to make sure all the relevant fields appear.
And the same form is used in Collections > Repository Management >> Remote >> Configure, where it has a different set of fields and where username is not write-only (=can only delete/change when editing, but not see)
it might also make sense to check there is no Token field and no YAML Requirements

@ShaiahWren ShaiahWren force-pushed the create-cypress-test-for-remote-registry-add-form branch from cb567d0 to cf78b5e Compare October 19, 2021 15:40
@ShaiahWren
Copy link
Contributor Author

ShaiahWren commented Oct 19, 2021 •
edited
Loading

@himdel How do you suggest making a mock upload for the client key and client certificate fields?

@ShaiahWren ShaiahWren force-pushed the create-cypress-test-for-remote-registry-add-form branch from cf78b5e to 739ddef Compare October 19, 2021 19:58
@ZitaNemeckova
Copy link
Member

ZitaNemeckova commented Oct 26, 2021 •
edited
Loading

@ShaiahWren For upload you can use cypress-file-upload

run npm install --save-dev cypress-file-upload in test file

Then import it https://github.com/ansible/ansible-hub-ui/pull/1084/files#diff-f4ccba99a203f90dfdca7435832cfa68e0ddd4865c0abe3adde145a056a14309R18

Add a file like this https://github.com/ansible/ansible-hub-ui/pull/1084/files#diff-d0e144773f4f18181a714e49f1f969dec046d4c64062d3046554473e16bfcee1

And use it https://github.com/ansible/ansible-hub-ui/pull/1084/files#diff-d35b724686f5e6f18176d4eea2bcdb23970f2a1146f81bd582a7a18ee9d7f08bR24

I'm having trouble using it for tar.gz but I think it should work with normal formats :)

@himdel
Copy link
Collaborator

himdel commented Oct 27, 2021

(Re uploads, we settled on just making sure the fields are there in the form for now, since we don't quite know what to upload.)

@himdel
Copy link
Collaborator

himdel commented Oct 27, 2021

(Also needs a rebase)

@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 27, 2021
@ShaiahWren ShaiahWren force-pushed the create-cypress-test-for-remote-registry-add-form branch from 739ddef to 5828cc8 Compare October 27, 2021 15:05
@ShaiahWren ShaiahWren requested a review from himdel October 27, 2021 15:06
@ShaiahWren ShaiahWren force-pushed the create-cypress-test-for-remote-registry-add-form branch from 5828cc8 to 78c07c6 Compare November 1, 2021 15:42
@ShaiahWren ShaiahWren requested a review from himdel November 1, 2021 15:42
@ShaiahWren ShaiahWren force-pushed the create-cypress-test-for-remote-registry-add-form branch from 78c07c6 to 5984e69 Compare November 1, 2021 17:39
@ShaiahWren ShaiahWren force-pushed the create-cypress-test-for-remote-registry-add-form branch from 5984e69 to 34ee7a2 Compare November 3, 2021 22:39
himdel
himdel approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@ShaiahWren ShaiahWren force-pushed the create-cypress-test-for-remote-registry-add-form branch from 4445c79 to 321ecd3 Compare November 4, 2021 02:58
@ShaiahWren
Copy link
Contributor Author

@himdel , I just removed the spaces from the input selectors. Lmk if it still looks good :)

@himdel
Copy link
Collaborator

himdel commented Nov 4, 2021

Even better 👍 :)

@ShaiahWren ShaiahWren merged commit 84a978e into ansible:master Nov 4, 2021
@ShaiahWren ShaiahWren deleted the create-cypress-test-for-remote-registry-add-form branch November 4, 2021 03:27
@patchback
Copy link

patchback bot commented Nov 4, 2021 •
edited
Loading

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/84a978ee4507d8ce4e55b14b9d37ed8e56e6a03c/pr-1112

Backported as #1194

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 4, 2021
@ShaiahWren
add tests to remote registries form (#1112)
09f6a37 
* add tests to remote registries form

* make params optional

* use new cy command for addRemoteRegistry

* remove spaces from selectors

(cherry picked from commit 84a978e)
@patchback patchback bot mentioned this pull request Nov 4, 2021
Merged
himdel pushed a commit that referenced this pull request Nov 4, 2021
@patchback @ShaiahWren
add tests to remote registries form (#1112) (#1194)
b8e5e30 
* add tests to remote registries form

* make params optional

* use new cy command for addRemoteRegistry

* remove spaces from selectors

(cherry picked from commit 84a978e)

Co-authored-by: Shaiah Emigh-Doyle <64337863+ShaiahWren@users.noreply.github.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Nov 4, 2021
@ekmixon ekmixon mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@ZitaNemeckova ZitaNemeckova Awaiting requested review from ZitaNemeckova

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaiahWren @himdel @ZitaNemeckova