Cypress test for execution environments #1138
Merged
+127
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| it('checks the EE detail view', () => { | ||
| cy.get('a[href="/ui/containers/alpine338"]').click(); |
There was a problem hiding this comment.
We should be testing all tabs and their content. But given the deadline (and vague issue description O:)) it can be added in followup PR :)
|
@ShaiahWren Nice work! I'm leaving it up to you if you want to address all reviews here or just the one with saving readme :) |
ShaiahWren
force-pushed
the
cypress-test-for-execution-environments
branch
4 times, most recently
from
1d59e8d to
bbe4361
Compare
himdel
reviewed
Oct 30, 2021
himdel
reviewed
Oct 30, 2021
ShaiahWren
force-pushed
the
cypress-test-for-execution-environments
branch
from
bbe4361 to
6aec628
Compare
ShaiahWren
force-pushed
the
cypress-test-for-execution-environments
branch
from
6aec628 to
d93a948
Compare
|
Finally closing this pr. :) |
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1192 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
* testing execution exvironments * testing execution environments * remove registries/containers before testing (cherry picked from commit e237e53)
himdel
pushed a commit
that referenced
this pull request
Nov 3, 2021
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/AAH-1001
This pr tests Execution Environments - list view, detail view, and readme file.
As it is the tests are fairly simple. Lmk what other details you would like me to include.