Fix i18n issue #1216
Merged
Fix i18n issue #1216
+5,318
−2,663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
fix_l10n
branch
3 times, most recently
from
8e57db7 to
5a28822
Compare
ZitaNemeckova
added
backport-4.4
ZitaNemeckova
force-pushed
the
fix_l10n
branch
from
8131352 to
5a28822
Compare
ZitaNemeckova
changed the title
himdel
reviewed
Nov 8, 2021
Extract and compile new translatable strings to prevent wrong display in prod that looks like "string{0}string"
ZitaNemeckova
force-pushed
the
fix_l10n
branch
from
5a28822 to
07de8ce
Compare
himdel
approved these changes
Nov 8, 2021
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1218 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
* Fixing the test to prove translatedable strings are correct in prod * Fixes https://issues.redhat.com/browse/AAH-982 Extract and compile new translatable strings to prevent wrong display in prod that looks like "string{0}string" (cherry picked from commit 8b34c28)
himdel
pushed a commit
that referenced
this pull request
Nov 8, 2021
* Fixing the test to prove translatedable strings are correct in prod * Fixes https://issues.redhat.com/browse/AAH-982 Extract and compile new translatable strings to prevent wrong display in prod that looks like "string{0}string" (cherry picked from commit 8b34c28) Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAH-982
Adding missing compiled files to fix
"string {0} string"issue in prod.Fixed a test that was failing because of it to prove it's fixed.
Before the fix:
After:
🟢
@himdel Someone's gonna have the most new lines Milan Zazrivec style :D