-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create single 'Get Token' button for all local repos #1257
Conversation
@@ -179,6 +181,13 @@ class RepositoryList extends React.Component<RouteComponentProps, IState> { | |||
/> | |||
</div> | |||
</div> | |||
{params.tab == 'local' && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShaiahWren This should be in BaseHeader
param pageControls
. See
ansible-hub-ui/src/containers/group-management/group-detail.tsx
Lines 200 to 215 in 2e1946f
<BaseHeader | |
title={ | |
editPermissions && params.tab == 'permissions' | |
? t`Edit group permissions` | |
: group.name | |
} | |
breadcrumbs={ | |
<Breadcrumbs | |
links={[ | |
{ url: Paths.groupList, name: t`Groups` }, | |
{ name: group.name }, | |
]} | |
/> | |
} | |
pageControls={this.renderControls()} | |
> |
After moving it there shouldn't be any need for new CSS and it should consistent with similar pages.
33468e8
to
21f38d5
Compare
(adding this to a few recently updated PRs…) We need CI in this repo that enforces this, but for now please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Don't forget to fix a commit according to Andrew's comment before merging :)
Issue: AAH-903
21f38d5
to
b7d39a6
Compare
Issue: AAH-903 |
Backport to stable-4.4: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 0fad2f9 on top of patchback/backports/stable-4.4/0fad2f9766807b5c55cd9442e5dd3ac69152a9e7/pr-1257 Backporting merged PR #1257 into master
🤖 @patchback |
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1375 🤖 @patchback |
Issue: https://issues.redhat.com/browse/AAH-903
Assignment:
Before:

After:
