Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add development dockerfile. #143

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Add development dockerfile. #143

merged 3 commits into from
Jun 2, 2020

Conversation

newswangerd
Copy link
Member

@newswangerd newswangerd commented May 28, 2020 •
edited
Loading

@newswangerd newswangerd mentioned this pull request May 28, 2020
Merged
@newswangerd newswangerd requested a review from cutwater May 28, 2020 20:54
cutwater
cutwater approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@cutwater cutwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Otherwise LGTM.

Dockerfile Outdated
WORKDIR /hub/

RUN mkdir -p /hub/app/ && \
apk add git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apk add git
apk add --no-cache git

@newswangerd newswangerd force-pushed the feature/dockerized-dev branch from 1f808ea to 0867f7a Compare June 2, 2020 13:44
@newswangerd newswangerd merged commit 8ba3c68 into ansible:master Jun 2, 2020
@newswangerd newswangerd deleted the feature/dockerized-dev branch November 3, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutwater cutwater cutwater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newswangerd @cutwater