Fix unique key warning in collection header #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerabekjiri
changed the title
jerabekjiri
force-pushed
the
fix-unique-key-collection-header
branch
from
c7ecac3 to
444e4c3
Compare
himdel
reviewed
Feb 4, 2022
|
Can you do exactly like this so no merge conflicts will arise for me in the Signing PR? |
No-Issue
himdel
reviewed
Feb 7, 2022
| </DropdownItem> | ||
| </div> | ||
| <DropdownItem | ||
| data-cy='delete-version-dropdown' |
There was a problem hiding this comment.
the same data-cy value is already used in the first DropdownItem here
EDIT: never mind, they're all different
key |
data-cy |
|---|---|
delete-collection-enabled |
delete-collection-dropdown |
delete-collection-disabled |
- |
delete-version-dropdown |
delete-collection-version |
LGTM :)
|
I am merging this for my PR so I don't have to rebase twice. |
|
@brumik sorry, I thought I already merged this, thanks 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Issue
A small fix to resolve the unique key warning in the CollectionHeader component, that has been bothering the console log for a while.
