Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow content in ImportConsole on My imports Page #1711

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix overflow content in ImportConsole on My imports Page #1711

merged 1 commit into from
Mar 16, 2022

Conversation

jerabekjiri
Copy link
Contributor

Issue: AAH-396

This fixes content overflow in ImportConsole component when the text is too long in message-list element or when the error pops up in title-bar element.

before:
Screenshot from 2022-03-02 11-58-56

after:
Screenshot from 2022-03-02 12-29-11

@jerabekjiri jerabekjiri added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) backport-4.4 This PR should be backported to stable-4.4 (2.1) labels Mar 2, 2022
@ShaiahWren
Copy link
Contributor

This LGTM :)

ShaiahWren
ShaiahWren approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@ShaiahWren ShaiahWren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@jerabekjiri
Fix content overflow
10eef55 
Issue: AAH-396
@jerabekjiri jerabekjiri force-pushed the fix-import-console-overflow branch from 1ff0ad2 to 10eef55 Compare March 7, 2022 22:38
@jerabekjiri jerabekjiri requested a review from himdel March 11, 2022 15:56
@jerabekjiri jerabekjiri merged commit 476a4cf into ansible:master Mar 16, 2022
@patchback
Copy link

patchback bot commented Mar 16, 2022 •
edited
Loading

Backport to stable-4.2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.2/476a4cfd8a26141d11dd1b52612726d69429eb0d/pr-1711

Backported as #1771

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 16, 2022
@jerabekjiri @patchback
Fix content overflow (#1711)
bf911ed 
Issue: AAH-396
(cherry picked from commit 476a4cf)
@patchback patchback bot mentioned this pull request Mar 16, 2022
Merged
@patchback
Copy link

patchback bot commented Mar 16, 2022 •
edited
Loading

Backport to stable-4.3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.3/476a4cfd8a26141d11dd1b52612726d69429eb0d/pr-1711

Backported as #1772

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 16, 2022
@jerabekjiri @patchback
Fix content overflow (#1711)
f2bcb09 
Issue: AAH-396
(cherry picked from commit 476a4cf)
@patchback patchback bot mentioned this pull request Mar 16, 2022
Merged
@patchback
Copy link

patchback bot commented Mar 16, 2022 •
edited
Loading

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/476a4cfd8a26141d11dd1b52612726d69429eb0d/pr-1711

Backported as #1773

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 16, 2022
@jerabekjiri @patchback
Fix content overflow (#1711)
7ae87bc 
Issue: AAH-396
(cherry picked from commit 476a4cf)
@patchback patchback bot mentioned this pull request Mar 16, 2022
Merged
himdel pushed a commit that referenced this pull request Mar 17, 2022
@patchback @jerabekjiri
Fix content overflow (#1711) (#1773)
8078dc8 
Issue: AAH-396
(cherry picked from commit 476a4cf)

Co-authored-by: Jiří Jeřábek <Jerabekjirka@email.cz>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Mar 17, 2022
himdel pushed a commit that referenced this pull request Mar 17, 2022
@patchback @jerabekjiri
Fix content overflow (#1711) (#1772)
5580b21 
Issue: AAH-396
(cherry picked from commit 476a4cf)

Co-authored-by: Jiří Jeřábek <Jerabekjirka@email.cz>
himdel pushed a commit that referenced this pull request Mar 17, 2022
@patchback @jerabekjiri
Fix content overflow (#1711) (#1771)
2696c7f 
Issue: AAH-396
(cherry picked from commit 476a4cf)

Co-authored-by: Jiří Jeřábek <Jerabekjirka@email.cz>
@github-actions github-actions bot added backported-4.3 This PR has been backported to stable-4.3 (2.0) backported-4.2 This PR has been backported to stable-4.2 (1.2) labels Mar 17, 2022
@himdel himdel mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@ShaiahWren ShaiahWren ShaiahWren approved these changes

@MilanPospisil MilanPospisil Awaiting requested review from MilanPospisil

Assignees
No one assigned
Labels
backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerabekjiri @ShaiahWren @himdel