Edit remote repo #2064
Edit remote repo #2064
Conversation
ShaiahWren
force-pushed
the
edit-remote-repo
branch
2 times, most recently
from
d925f55 to
cd997d2
Compare
|
is this about #1833 (comment) ? If so, that comment was just about testing the "registry" part of the form in the (existing) registry tests. If not .. what's the difference here? |
|
@himdel I moved the 'edit' portion of the repo management pr over here, per @ZitaNemeckova's request. |
ShaiahWren
force-pushed
the
edit-remote-repo
branch
from
d4790b4 to
0a0748d
Compare
|
Ah, so just splitting a big pr, makes sense :) LGTM, except this seems to break the same task* tests |
|
..although, is there one type missing? the form works in 4 modes .. |
| cy.get('input[id="username"]').should('have.value', 'test'); | ||
| cy.get('input[id="proxy_url"]').should('have.value', 'https://example.org'); | ||
| cy.get('input[id="proxy_username"]').should('have.value', 'test'); | ||
| cy.intercept( |
There was a problem hiding this comment.
No need to define it again. You could use @editCommunityRemote again.
| .click({ multiple: true }); | ||
| cy.get('input[id="proxy_url"]').clear(); | ||
| cy.get('input[id="proxy_username"]').clear(); | ||
| cy.contains('Save').click(); |
There was a problem hiding this comment.
There's no check the save was a success?
| cy.get('input[id="proxy_username"]').should('have.value', 'test'); | ||
| cy.intercept( | ||
| 'PUT', | ||
| Cypress.env('prefix') + 'content/community/v3/sync/config/', |
There was a problem hiding this comment.
Is it intentional that it's a community URL?
There was a problem hiding this comment.
Yes - any reason it can't be?
There was a problem hiding this comment.
@ZitaNemeckova now it is using rh-certified.
|
@ShaiahWren Great job! I added few comments. |
ShaiahWren
force-pushed
the
edit-remote-repo
branch
2 times, most recently
from
614f813 to
4fa96ca
Compare
| .click({ multiple: true }); | ||
| cy.get('input[id="proxy_url"]').clear(); | ||
| cy.get('input[id="proxy_username"]').clear(); | ||
| cy.contains('Save').click(); |
There was a problem hiding this comment.
There's no check that the save is a success. There should be a bit of code that checks that username, proxy_url, proxy_username are empty after the save. This applies to the community test as well.
Otherwise LGTM 👍
Issue: AAH-618
Issue: AAH-618
Issue: AAH-618
Issue: AAH-618
Issue: AAH-618
Issue: AAH-618
ShaiahWren
force-pushed
the
edit-remote-repo
branch
from
57c9ef4 to
c997500
Compare
|
Pr closed. |
* edit remote repo Issue: AAH-618 * edit a remote repo Issue: AAH-618 * adjust tests for rh-certified Issue: AAH-618 * add to changelog Issue: AAH-618 * check for visibility on cy.eq() calls Issue: AAH-618 * remove config button test - it won't appear anyway No-Issue * confirm all values are cleared Issue: AAH-618
Issue: https://issues.redhat.com/browse/AAH-618
Moving 'edit remote repo' testing from #1833 to a separate pr.
Noting that there is very limited error handling with regard to input length, spaces, etc on all inputs except the URL.