Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standalone config - change pulp api path to '/api/automation-hub/pulp/api/v3/' (dev) or '/api/galaxy/pulp/api/v3/' (prod) #2135

Merged
merged 3 commits into from
May 30, 2022
Merged

standalone config - change pulp api path to '/api/automation-hub/pulp/api/v3/' (dev) or '/api/galaxy/pulp/api/v3/' (prod) #2135

merged 3 commits into from
May 30, 2022

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented May 30, 2022 •
edited
Loading

ansible/galaxy_ng#1247 was merged, so tasks won't work in dev ui without this

Cc @awcrosby .. do you know what happens for standalone prod? Should we change the pulp apis to /api/galaxy/pulp/api/v3/ or do they stay in the original place?

@himdel
standalone.dev config - change pulp api path to '/api/automation-hub/…
8f98b32 
…pulp/api/v3/'

ansible/galaxy_ng#1247 was merged, so task won't work in dev ui without this

No-Issue
(but related to AAH-1544)
@himdel himdel force-pushed the pulp-api-standalone branch from 09402ab to 8f98b32 Compare May 30, 2022 12:40
@himdel
Copy link
Collaborator Author

himdel commented May 30, 2022 •
edited
Loading

Before second commit (and also everywhere on master now):

✖ 6 of 35 failed (17%) 150 134 7 1 8
✖ execution_environments_edit.js 2 - 2 - -
✖ execution_environments_use_in_controller.js 5 - 1 - 4
✖ imports_filter.js 10 5 1 - 4
✖ task_list.js 1 - 1 - -
✖ task_management_detail.js 1 - 1 - -
✖ task_status.js 1 - 1 - -

After second commit:

✖ 1 of 35 failed (3%) 150 148 1 1 -
✖ task_status.js 1 - 1 - -

(Third ✔️ :))

.. yeah, I think we can definitely say that prod needs /api/galaxy/pulp/api/v3/, and thus that all the new cypress failures are related to ansible/galaxy_ng#1247 (AAH-1544) :)

This may also cause issues with downstream builds though, but that's for a separate MR.

@himdel himdel changed the title standalone.dev config - change pulp api path to '/api/automation-hub/pulp/api/v3/' standalone config - change pulp api path to '/api/automation-hub/pulp/api/v3/' (dev) or '/api/galaxy/pulp/api/v3/' (prod) May 30, 2022
@himdel
Copy link
Collaborator Author

himdel commented May 30, 2022

Merging to fix tests on master

@himdel himdel merged commit d07ba0f into ansible:master May 30, 2022
@himdel himdel deleted the pulp-api-standalone branch May 30, 2022 14:46
This was referenced May 30, 2022
Merged
Merged
@awcrosby
Copy link
Contributor

@himdel the pulp api moved for all deployment modes, so for standlone the UI will need to access it in it's new location. We also plan to add a redirect for standalone.

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Aug 29, 2022
@himdel
PULP_API_BASE_PATH - hardcode to use API_BASE_PATH + 'pulp/api/v3/'
499cad4 
related to packaging!11, ansible#2135
mostly undoes ansible#1857 config changes but not code changes

`packaging/roles/publish/files/config/downstream.webpack.config.js` can't easily have version-dependent logic,
so having individual webpack configs provide `PULP_API_BASE_PATH` doesn't quite work,
but having the constant available in code is still useful.

=> ignoring any PULP_API_BASE_PATH config options or env variables, hardcoding PULP_API_BASE_PATH global to be based on API_BASE_PATH in 4.6+
(for 4.5 and older, the url is just /pulp/api/v3/)
@himdel himdel mentioned this pull request Aug 29, 2022
Merged
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Aug 29, 2022
@himdel
PULP_API_BASE_PATH - hardcode to use API_BASE_PATH + 'pulp/api/v3/'
55b2279 
related to packaging!11, ansible#2135
mostly undoes ansible#1857 config changes but not code changes

`packaging/roles/publish/files/config/downstream.webpack.config.js` can't easily have version-dependent logic,
so having individual webpack configs provide `PULP_API_BASE_PATH` doesn't quite work,
but having the constant available in code is still useful.

=> ignoring any PULP_API_BASE_PATH config options or env variables, hardcoding PULP_API_BASE_PATH global to be based on API_BASE_PATH in 4.6+
(for 4.5 and older, the url is just /pulp/api/v3/)

No-Issue
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Aug 30, 2022
@himdel
PULP_API_BASE_PATH - hardcode to use API_BASE_PATH + 'pulp/api/v3/'
571d568 
related to packaging!11, ansible#2135
mostly undoes ansible#1857 config changes but not code changes

`packaging/roles/publish/files/config/downstream.webpack.config.js` can't easily have version-dependent logic,
so having individual webpack configs provide `PULP_API_BASE_PATH` doesn't quite work,
but having the constant available in code is still useful.

=> ignoring any PULP_API_BASE_PATH config options or env variables, hardcoding PULP_API_BASE_PATH global to be based on API_BASE_PATH in 4.6+
(for 4.5 and older, the url is just /pulp/api/v3/)

No-Issue
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Aug 30, 2022
@himdel
PULP_API_BASE_PATH - hardcode to use API_BASE_PATH + 'pulp/api/v3/'
ec9fd7d 
related to packaging!11, ansible#2135
mostly undoes ansible#1857 config changes but not code changes

`packaging/roles/publish/files/config/downstream.webpack.config.js` can't easily have version-dependent logic,
so having individual webpack configs provide `PULP_API_BASE_PATH` doesn't quite work,
but having the constant available in code is still useful.

=> ignoring any PULP_API_BASE_PATH config options or env variables, hardcoding PULP_API_BASE_PATH global to be based on API_BASE_PATH in 4.6+
(for 4.5 and older, the url is just /pulp/api/v3/)

No-Issue
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Sep 12, 2022
@himdel
PULP_API_BASE_PATH - hardcode to use API_BASE_PATH + 'pulp/api/v3/'
0aab8e6 
related to packaging!11, ansible#2135
mostly undoes ansible#1857 config changes but not code changes

`packaging/roles/publish/files/config/downstream.webpack.config.js` can't easily have version-dependent logic,
so having individual webpack configs provide `PULP_API_BASE_PATH` doesn't quite work,
but having the constant available in code is still useful.

=> ignoring any PULP_API_BASE_PATH config options or env variables, hardcoding PULP_API_BASE_PATH global to be based on API_BASE_PATH in 4.6+
(for 4.5 and older, the url is just /pulp/api/v3/)

No-Issue
himdel added a commit that referenced this pull request Sep 12, 2022
@himdel
PULP_API_BASE_PATH - hardcode to use API_BASE_PATH + 'pulp/api/v3/' (#…
9236273 
…2501)

* PULP_API_BASE_PATH - hardcode to use API_BASE_PATH + 'pulp/api/v3/'

related to packaging!11, #2135
mostly undoes #1857 config changes but not code changes

`packaging/roles/publish/files/config/downstream.webpack.config.js` can't easily have version-dependent logic,
so having individual webpack configs provide `PULP_API_BASE_PATH` doesn't quite work,
but having the constant available in code is still useful.

=> ignoring any PULP_API_BASE_PATH config options or env variables, hardcoding PULP_API_BASE_PATH global to be based on API_BASE_PATH in 4.6+
(for 4.5 and older, the url is just /pulp/api/v3/)

No-Issue

* test/: consistently use pulpPrefix for PULP_API_BASE_PATH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himdel @awcrosby