[PR #2112/0ca835c1 backport][stable-4.4] Use GALAXY_MINIMUM_PASSWORD_LENGTH in user-form help message #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
himdel
deleted the
patchback/backports/stable-4.4/0ca835c16161972397c791f1c571dfdf0a0efa61/pr-2112
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2112 as merged into master (0ca835c).
API parts come from ansible/galaxy_ng#1253,
we have a new
GALAXY_MINIMUM_PASSWORD_LENGTHsetting coming from the API, defaults tonullso we're still providing the 9 default.When overidden, the prompt will show the right number now.
(The actual on save validation still happens server side, that already provides the right message.)
Fixes https://issues.redhat.com/browse/AAH-1573
note that
MinimumPasswordLengthValidatorjust uses python'slen(), so the number actually means codepoints, not characters .. so this will actually still allow 5 character passwords if each character has accents done through a modifier .. but we shouldn't expect users to know about Unicode.