Make logo clickable #248
Merged
Make logo clickable #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newswangerd
reviewed
Nov 18, 2020
| @@ -223,7 +223,11 @@ class App extends React.Component<RouteComponentProps, IState> { | |||
|
|
|||
| const Header = ( | |||
| <PageHeader | |||
| logo={<SmallLogo alt='Galaxy Logo'></SmallLogo>} | |||
| logo={ | |||
| <a href={'/'}> | |||
There was a problem hiding this comment.
Why not Link?
Also, unrelated, but we should change Galaxy Logo to use the APPLICATION_NAME
newswangerd
added
the
backport-4.2
Fix-Issue: AAH-162
ZitaNemeckova
force-pushed
the
logo_clickable
branch
from
c79653f to
de7df1a
Compare
newswangerd
approved these changes
Nov 19, 2020
newswangerd
pushed a commit
that referenced
this pull request
Nov 19, 2020
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Mar 8, 2021
Introduced in ansible#248, PageHeader wraps logo in `a` by default and the logo became a Link, leading to `a > a > img` We can override the upper `a` using `logoComponent` (https://www.patternfly.org/v4/components/page#pageheader), doing that.
ZitaNemeckova
pushed a commit
that referenced
this pull request
Mar 9, 2021
) * Delete modal - create a shared delete modal, use for users, groups using title + titleVariant instead of a custom modal header fixes the font size and icon alignment, lowercasing the second word (Delete user => Delete group) and adding a description with the name in bold * gitignore/prettierignore vim swap files otherwise, `git commit` fails when a file is being edited, because prettier fails with [error] No parser could be inferred for file: src/containers/group-management/.group-detail.tsx.swp * group-detail: add a Delete button, similar to User detail also behaves the same way, alerts and redirects to group list after success * group-detail: use DeleteModal to confirm user removal from group * group-detail: list affected users when deleting group wip: deal with more users, list screen * group-detail: fix Users tab count, sort default sort pretended to be username but the list was unsorted until the sort order was changed and there was only 1 page because the count came from results length, limited by page size * group-detail: show max 10 users, just the count on more * Fix `<a> cannot appear as a descendant of <a>` warning Introduced in #248, PageHeader wraps logo in `a` by default and the logo became a Link, leading to `a > a > img` We can override the upper `a` using `logoComponent` (https://www.patternfly.org/v4/components/page#pageheader), doing that. * DeleteGroupModal: move delete group modal logic from group-detail to own modal, use from group-list * users: use UserType[] instead of any[]
ZitaNemeckova
added
the
backported-4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix-Issue: AAH-162