Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress - fix after pulp-ci-centos s6-overlay upgrade #2503

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Aug 30, 2022

After pulp/pulp-oci-images#231, the path to restart the pulpcore-api service has changed, leading to cypress failing to build on CI: https://github.com/ansible/ansible-hub-ui/runs/8098212627?check_suite_focus=true

s6-svc: fatal: unable to control /var/run/s6/services/pulpcore-api: No such file or directory

=> updating the path.

find /var/run/s6* -name pulpcore-api finds 2 options...

/var/run/s6/db/servicedirs/pulpcore-api
/var/run/s6-rc:s6-rc-init:GFjbCb/servicedirs/pulpcore-api

the first fails with s6-svc: fatal: unable to control /var/run/s6/db/servicedirs/pulpcore-api: supervisor not listening
the second seems to work, except the GFjbCb bit is a random hash that keeps changing => assuming /var/run/s6-rc:*/servicedirs/pulpcore-api will always find just one option.

... but there's also a /var/run/s6-rc symlink to the right s6-rc:s6-rc-init:GFjbCb dir.

=> using /var/run/s6-rc/servicesdirs/pulpcore-api now

After pulp/pulp-oci-images#231, the path to restart the pulpcore-api service has changed,
updating.

`find /var/run/s6* -name pulpcore-api` finds 2 options...
    /var/run/s6/db/servicedirs/pulpcore-api
    /var/run/s6-rc:s6-rc-init:GFjbCb/servicedirs/pulpcore-api

the first fails with `s6-svc: fatal: unable to control /var/run/s6/db/servicedirs/pulpcore-api: supervisor not listening`
the second seems to work, except the `GFjbCb` bit is a random hash that keeps changing => assuming /var/run/s6-rc:*/ will always find just one option

No-Issue
@himdel himdel changed the title test test breakage Cypress - fix after pulp-ci-centos s6-overlay upgrade Aug 30, 2022
@himdel himdel marked this pull request as ready for review August 30, 2022 19:22
@himdel
Copy link
Collaborator Author

himdel commented Aug 31, 2022

Merging to get tests green

@himdel himdel merged commit 8e11117 into ansible:master Aug 31, 2022
@himdel himdel deleted the test-test branch August 31, 2022 12:41
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Aug 31, 2022
* Cypress - fix after pulp-ci-centos s6-overlay upgrade

After pulp/pulp-oci-images#231, the path to restart the pulpcore-api service has changed,
updating.

`find /var/run/s6* -name pulpcore-api` finds 2 options...
    /var/run/s6/db/servicedirs/pulpcore-api
    /var/run/s6-rc:s6-rc-init:GFjbCb/servicedirs/pulpcore-api

the first fails with `s6-svc: fatal: unable to control /var/run/s6/db/servicedirs/pulpcore-api: supervisor not listening`
the second seems to work, except the `GFjbCb` bit is a random hash that keeps changing => assuming /var/run/s6-rc:*/ will always find just one option

No-Issue

* Prefer /var/run/s6-rc/ symlink over /var/run/s6-rc:s6-rc-init:RANDOM_HASH/

(cherry picked from commit 8e11117)
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Aug 31, 2022
* Cypress - fix after pulp-ci-centos s6-overlay upgrade

After pulp/pulp-oci-images#231, the path to restart the pulpcore-api service has changed,
updating.

`find /var/run/s6* -name pulpcore-api` finds 2 options...
    /var/run/s6/db/servicedirs/pulpcore-api
    /var/run/s6-rc:s6-rc-init:GFjbCb/servicedirs/pulpcore-api

the first fails with `s6-svc: fatal: unable to control /var/run/s6/db/servicedirs/pulpcore-api: supervisor not listening`
the second seems to work, except the `GFjbCb` bit is a random hash that keeps changing => assuming /var/run/s6-rc:*/ will always find just one option

No-Issue

* Prefer /var/run/s6-rc/ symlink over /var/run/s6-rc:s6-rc-init:RANDOM_HASH/

(cherry picked from commit 8e11117)
@himdel
Copy link
Collaborator Author

himdel commented Aug 31, 2022

Does NOT need a backport for now, looks like the 3.15 and 3.18 images still use the old s6 service paths.

@himdel
Copy link
Collaborator Author

himdel commented Sep 1, 2022

Ok, does seem to be needed now for 4.4: https://github.com/ansible/ansible-hub-ui/runs/8114735243?check_suite_focus=true
But not yet for 4.5 (https://github.com/ansible/ansible-hub-ui/runs/8138567958?check_suite_focus=true)

EDIT: Oh never mind, ordering, #2512 was created before merging #2500, so it was still trying to use pulp-ci-centos:latest, instead of pulp-ci-centos:3.15

@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Sep 1, 2022
@patchback

This comment was marked as outdated.

@himdel himdel removed the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant