deploy-cloud, base config: add explicit deployment config to build stage-stable and stage-beta both from master #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age-stable and stage-beta both from master npm run deploy reads the current branch name (in cloud mode) and decides to build a beta version when the branch is master but since ansible#2308, we're deploying to stage-stable as well leading to issues on stage-stable: Loading chunk 849 failed. (error: https://console.stage.redhat.com/beta/apps/automation-hub/js/849.1661953046888.a80f84b3e77abc4bde6d.js) adding a HUB_CLOUD_BETA env var to override the autodetection, and building with HUB_CLOUD_BETA=true for stage-beta, HUB_CLOUD_BETA=false for stage-stable, and no override for prod builds, as before. No-Issue
|
This should fix stage-stable deploys.. I hope :) |
awcrosby
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run deployreads the current branch name (in cloud mode) and decides to build a beta version when the branch ismasterbut since #2308, we're deploying to stage-stable as well, leading to issues on stage-stable:
=> adding a
HUB_CLOUD_BETAenv var to override the autodetection,and building with
HUB_CLOUD_BETA=truefor stage-beta,HUB_CLOUD_BETA=falsefor stage-stable,and no override for prod builds, as before.
(and moving the
npm run deploycall tocustom_release.shso we can run it twice from master)(The
deploymentconfig gets used here: https://github.com/RedHatInsights/frontend-components/blob/9766d2c07b0b62a4410956be85974c06264fcc7c/packages/config/index.js#L37 )