Fix missing versions in Aboutt Modal #254
Merged
+118
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
added
the
backport-4.2
ZitaNemeckova
force-pushed
the
fix_about_modal
branch
from
6495ba9 to
4815fe5
Compare
newswangerd
reviewed
Nov 20, 2020
| console.log('componentDidMount'); | ||
| ApplicationInfoAPI.get('') | ||
| .then(result => { | ||
| console.log(result); |
There was a problem hiding this comment.
Removed all console.logs
| applicationInfo: { server_version: string; pulp_ansible_version: string }; | ||
| } | ||
|
|
||
| export class AboutModalWindow extends React.Component<IProps, IState> { |
There was a problem hiding this comment.
I'm a little conflicted about classifying this as a component instead of a container. On one hand, it's making API requests and it has zero re-usability. On the other hand It's not a standalone page like all of our other containers are.
My gut reaction is to move this into containers. What do you think?
ZitaNemeckova
force-pushed
the
fix_about_modal
branch
from
4815fe5 to
107d29e
Compare
Move AboutModal to be a component Fix-Issue: AAH-161
ZitaNemeckova
force-pushed
the
fix_about_modal
branch
from
107d29e to
9c8559c
Compare
newswangerd
approved these changes
Nov 20, 2020
newswangerd
pushed a commit
that referenced
this pull request
Nov 23, 2020
Merged
ZitaNemeckova
added
the
backported-4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move AboutModal to be a component to get componentDidMount to work properly.
Fix-Issue: AAH-161
Steps to reproduce:
Before:
After:
