Add test to ensure 'download_concurrency' config is surfaced. #280
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hendersonreed It fails sporadically for me on Chromium I think it needs to wait for |
|
Good to know - I'll add that wait after standup! Thanks. |
|
@ZitaNemeckova I added a wait but that ended up causing a different kind of error. I elected to use |
|
My remote repos are failed and the test tries to click the Kebab has a |
|
@ZitaNemeckova Updated - don't know why I didn't see that aria-label at first. Thanks for working through this with me! |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test just verifies that the option exists in the UI - I think that's all the coverage required in the UI tests. Thoughts/opinions/reviews/etcetera from @ZitaNemeckova and @ironfroggy are greatly appreciated.