Update groups on My profile to be a Label not an input #281
Conversation
Fixes-Issue: AAH-160
|
Hi Zita! The group labels you have on the screenshots should be chips, and it looks like they're missing some padding in between. [No groups] shouldn't be a label -- maybe either leave it blank or use plain text? @sbuenafe-rh Also, what's the super user checkbox and who gets to check/uncheck it? |
|
@ZitaNemeckova @fionayhlin yep the [No groups] should probably be left blank. If the super user checkbox is only read-only and no one can make any edits to this. Then we should just have labels for Super user and User |
|
Updated version: @sbuenafe-rh @fionayhlin Changed as suggested, please have a look. I just left plain text in Groups if there isn't any group. But I can change it if it looks bad. Thanks for review :) |
|
@ZitaNemeckova I think removing the plain text No groups and keeping it blank will be okay. And the rest of the changes for the Super user area looks good! |
newswangerd
added
the
backport-4.2
* Update groups on My profile to be a Label not an input Fixes-Issue: AAH-160 * Use chips and hide super user part from a user * Change super user checkbox to label * Rename super user to User type * Show nothing when no groups (cherry picked from commit 605dcef) Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
ZitaNemeckova
added
the
backported-4.2
Fixes-Issue: AAH-160
Before:
User is in groups:
User is not in a group:
After:
User is in groups:
User is not in a group
@sbuenafe-rh @fionayhlin What do you think? I'm not sure
No groupslooks good.