Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for AAH-160 #301

Merged

Conversation

hendersonreed
Copy link
Contributor

The change in commands.js was simply a missing parenthesis, and the
change in package.json is just whitespace (seems like it was automated,
I don't remember making that change.)

The change in commands.js was simply a missing parenthesis, and the
change in package.json is just whitespace (seems like it was automated,
I don't remember making that change.)
@newswangerd newswangerd added the backport-4.2 This PR should be backported to stable-4.2 (1.2) label Feb 11, 2021
@ZitaNemeckova
Copy link
Member

LGTM 👍 Thanks for catching missing paranthesis and whitespaces :)

@ZitaNemeckova ZitaNemeckova merged commit 564c41e into ansible:master Feb 11, 2021
This was referenced Apr 19, 2021
himdel pushed a commit to himdel/ansible-hub-ui that referenced this pull request Apr 19, 2021
The change in commands.js was simply a missing parenthesis, and the
change in package.json is just whitespace (seems like it was automated,
I don't remember making that change.)

(cherry picked from commit 564c41e)
himdel pushed a commit to himdel/ansible-hub-ui that referenced this pull request Apr 20, 2021
The change in commands.js was simply a missing parenthesis, and the
change in package.json is just whitespace (seems like it was automated,
I don't remember making that change.)

(cherry picked from commit 564c41e)
himdel added a commit that referenced this pull request Apr 20, 2021

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
…port multiple test PRs (#354)

* Add test for Group Management (#240)

* Add test for Group Management

* Add permissions to a group

* Add waiting for delete of a user/group to end and check that it ends with 204

* Admin user can add and remove users from a group

* Remove use of .click({force: true}) and fix it to make it work

* Add some waits and checks

* Use removeAllPermissions and use variable for types of permission

(cherry picked from commit 2a66eaa)

* Add test for AAH-160 (#301)

The change in commands.js was simply a missing parenthesis, and the
change in package.json is just whitespace (seems like it was automated,
I don't remember making that change.)

(cherry picked from commit 564c41e)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
Co-authored-by: Henderson Hummel <hhummel@redhat.com>
@himdel himdel added the backported-4.2 This PR has been backported to stable-4.2 (1.2) label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.2 This PR should be backported to stable-4.2 (1.2) backported-4.2 This PR has been backported to stable-4.2 (1.2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants