Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository form #313

Merged
merged 12 commits into from
Apr 16, 2021
Merged

Repository form #313

merged 12 commits into from
Apr 16, 2021

Conversation

ZitaNemeckova
Copy link
Member

@ZitaNemeckova ZitaNemeckova commented Mar 3, 2021

Container Registry -> select a container -> click Edit in right top corner.

Screenshot 2021-04-13 at 16 27 46

@ZitaNemeckova ZitaNemeckova force-pushed the repository_form branch 3 times, most recently from d108942 to 5279dad Compare March 24, 2021 09:27
@ZitaNemeckova ZitaNemeckova force-pushed the repository_form branch 4 times, most recently from b6f8891 to bc0b68d Compare April 13, 2021 13:41
@ZitaNemeckova ZitaNemeckova requested a review from himdel April 13, 2021 14:31
@himdel
Copy link
Collaborator

himdel commented Apr 13, 2021

We should move the Edit button from execution-environment-header to the top of the Detail tab, similar to #317.

Unless the idea is for the Edit button to work in all the tabs?

EDIT: works on all tabs now 👍

@ZitaNemeckova ZitaNemeckova force-pushed the repository_form branch 2 times, most recently from d833efa to ea973e4 Compare April 14, 2021 11:36
@ZitaNemeckova ZitaNemeckova changed the title [WIP] Repository form Repository form Apr 14, 2021
@himdel
Copy link
Collaborator

himdel commented Apr 14, 2021

From the UX meeting...

(A redesign of those components/dropping the modal can come later.)


Also, "Description" doesn't seem to get saved, and isn't displayed anywhere?

EDIT: saved, displayed in header 👍

Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like all outstanding issues are addressed 👍

Tested in UI, I'm not seeing any new issues 👍

@ZitaNemeckova ZitaNemeckova merged commit df6ab86 into ansible:master Apr 16, 2021
@ZitaNemeckova ZitaNemeckova deleted the repository_form branch April 16, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants