-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository form #313
Repository form #313
Conversation
4cd6e7f
to
9e1df31
Compare
d108942
to
5279dad
Compare
b6f8891
to
bc0b68d
Compare
We should move the Edit button from execution-environment-header to the top of the Detail tab, similar to #317. Unless the idea is for the Edit button to work in all the tabs? EDIT: works on all tabs now 👍 |
src/components/execution-environment-header/execution-environment-header.tsx
Outdated
Show resolved
Hide resolved
src/containers/execution-environment-detail/execution_environment_detail.tsx
Outdated
Show resolved
Hide resolved
d833efa
to
ea973e4
Compare
From the UX meeting...
(A redesign of those components/dropping the modal can come later.) Also, "Description" doesn't seem to get saved, and isn't displayed anywhere? EDIT: saved, displayed in header 👍 |
e0e73e5
to
90c70e5
Compare
789907b
to
52ac770
Compare
230ba4b
to
5520e61
Compare
5520e61
to
8ff4e05
Compare
Add Repositry edit form to Exec. Env.
…AMESPACE_PERMISSIONS for now
…how output correctly, change EE to container in permission human names
…g request with unchanged values and RBAC
8ff4e05
to
8a50b35
Compare
src/containers/execution-environment-detail/execution_environment_detail.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like all outstanding issues are addressed 👍
Tested in UI, I'm not seeing any new issues 👍
Container Registry -> select a container -> click Edit in right top corner.