user-form: only show "Passwords do not match" when there is confirmation password; make required when password

[himdel]

This fixes part of https://issues.redhat.com/browse/AAH-362 ...

"Passwords do not match" alert under password confirmation appears when user types in the "password" field

... and part of https://issues.redhat.com/browse/AAH-360

Password confirmation field should be mandatory

@sbuenafe-rh , @ZitaNemeckova I don't see any patternfly guidelines on how the password field + confirm password field combo should behave, so this is my best guess based on the assumption that the "Passwords do not match" message is not supposed to appear without any password there. (Which could be wrong given some of the effects below.)

So, this describes the create user/edit user form behaviour with this change in, in all the variants, I'm pretty sure the Save button is correct, not necessarily the rest :) .. I've added a question mark where I think something may be wrong, but if we make the field invalid when there is a password but no confirmation password, it implies that the message would appear when the user types in the password field.

• Create new user:

  • empty password:
    • empty confirm:
      Username, Password, Confirm are required
      Save is disabled
      no message, no invalid fields
    • nonempty confirm:
      Username, Password, Confirm are required
      Save is disabled
      yes message, confirm invalid
  • nonempty password:
    • empty confirm:
      Username, Password, Confirm are required
      Save is disabled
      no message, no invalid fields ❓
    • nonempty bad confirm:
      Username, Password, Confirm are required
      Save is disabled
      yes message, confirm invalid
    • nonempty good confirm:
      Username, Password, Confirm are required
      Save is enabled
      no message, confirm invalid

• Edit user:

  • placeholder password:
    • placeholder confirm:
      only Username required
      Save is enabled
      no message, no invalid fields
    • nonempty confirm:
      only Username required
      Save is disabled
      yes message, confirm invalid
  • nonempty password:
    • placeholder confirm:
      Username and Confirm are required
      Save is disabled
      no message, no invalid fields ❓
      maybe there should not be a placeholder confirm with nonempty password and appear empty ❓
    • nonempty bad confirm:
      Username and Confirm are required
      Save is disabled
      yes message, confirm invalid
    • nonempty good confirm:
      Username and Confirm are required
      Save is enabled
      no message, confirm invalid

As for the mandatory confirmation field, I've made it mandatory only when the password is required (new user), or already entered (edit user, after changing the password), hope that makes sense :).

---

https://issues.redhat.com/browse/AAH-362 also contains...

All fields should be mandatory(double check it's needed)

As far as the api/model is concerned, only username/username+password is required.
So the question is: should we require First name, Last name, and Email as well? (If so, I'll add it, it's a trivial change.)

[ZitaNemeckova]

LGTM 👍 UX approved as well 👍