[stable-4.5] Dead code cleanup, sync prettier config #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2023
Merged
himdel
force-pushed
the
45-no-insights
branch
from
a321dcd to
6acec85
Compare
himdel
force-pushed
the
45-no-insights
branch
3 times, most recently
from
1b05daa to
5774b1d
Compare
himdel
changed the title
No-Issue
and clean up unused exports (ansible#3178)
sort external imports first, then src/, then any relative paths sort imports by source name, sort specifiers bump prettier to 2.8 ensure app.scss goes before patternfly.scss (ansible#3198)
himdel
force-pushed
the
45-no-insights
branch
from
5774b1d to
16dc3f4
Compare
perl -i -npe 's/^export/import/' src/**/index.ts
npm run prettier
perl -i -npe 's/^import/export/' src/**/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(4.2: #3172, 4.3: eol, 4.4: #3173, 4.5: here, 4.6: #3175, master: #3176)
Follows #3142, #1921
We're still depending on redux transitively and have a bunch of configs that are always set to the same value because most but not all insights-related code was removed from stable branches.
Removing unused dependencies, code and configs.
Clean up unused exports - #3178
Update prettier, plugin sort imports - #3198