-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json - ensure npm<7, node 12 or 14 #333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm 7 comes with node 15 and uses a newer lockfile v2 format, which is ignored by previous versions of npm forcing the versions, so that doesn't happen, and updating the lockfile back to v1 when using a too new version: npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'ansible-hub-ui@0.1.0', npm WARN EBADENGINE required: { node: '>=12, <15', npm: '<7' }, npm WARN EBADENGINE current: { node: 'v15.11.0', npm: '7.6.0' } npm WARN EBADENGINE }
v1, and without insights-internal URLs
Rebased :) But depends on #337 for travis. |
newswangerd
approved these changes
Apr 7, 2021
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Apr 9, 2021
* package.json - ensure npm<7, node 12 or 14 npm 7 comes with node 15 and uses a newer lockfile v2 format, which is ignored by previous versions of npm forcing the versions, so that doesn't happen, and updating the lockfile back to v1 when using a too new version: npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'ansible-hub-ui@0.1.0', npm WARN EBADENGINE required: { node: '>=12, <15', npm: '<7' }, npm WARN EBADENGINE current: { node: 'v15.11.0', npm: '7.6.0' } npm WARN EBADENGINE } * Regenerate package-lock.json v1, and without insights-internal URLs (cherry picked from commit 5355521)
newswangerd
pushed a commit
that referenced
this pull request
Apr 9, 2021
* package.json - ensure npm<7, node 12 or 14 npm 7 comes with node 15 and uses a newer lockfile v2 format, which is ignored by previous versions of npm forcing the versions, so that doesn't happen, and updating the lockfile back to v1 when using a too new version: npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'ansible-hub-ui@0.1.0', npm WARN EBADENGINE required: { node: '>=12, <15', npm: '<7' }, npm WARN EBADENGINE current: { node: 'v15.11.0', npm: '7.6.0' } npm WARN EBADENGINE } * Regenerate package-lock.json v1, and without insights-internal URLs (cherry picked from commit 5355521)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-4.2
This PR should be backported to stable-4.2 (1.2)
backported-4.2
This PR has been backported to stable-4.2 (1.2)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm 7 comes with node 15 and uses a newer lockfile v2 format,
which is ignored by previous versions of npm
forcing the versions so that doesn't happen,
and updating the lockfile back to v1
(and removing the insights internal urls as well)
when using a too new version:
Cc @newswangerd