Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json - ensure npm<7, node 12 or 14 #333

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Mar 24, 2021

npm 7 comes with node 15 and uses a newer lockfile v2 format,
which is ignored by previous versions of npm

forcing the versions so that doesn't happen,
and updating the lockfile back to v1
(and removing the insights internal urls as well)

when using a too new version:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'ansible-hub-ui@0.1.0',
npm WARN EBADENGINE   required: { node: '>=12, <15', npm: '<7' },
npm WARN EBADENGINE   current: { node: 'v15.11.0', npm: '7.6.0' }
npm WARN EBADENGINE }

Cc @newswangerd

himdel added 2 commits March 31, 2021 19:12
npm 7 comes with node 15 and uses a newer lockfile v2 format,
which is ignored by previous versions of npm

forcing the versions, so that doesn't happen,
and updating the lockfile back to v1

when using a too new version:

    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: 'ansible-hub-ui@0.1.0',
    npm WARN EBADENGINE   required: { node: '>=12, <15', npm: '<7' },
    npm WARN EBADENGINE   current: { node: 'v15.11.0', npm: '7.6.0' }
    npm WARN EBADENGINE }
v1, and without insights-internal URLs
@himdel
Copy link
Collaborator Author

himdel commented Mar 31, 2021

Rebased :)

But depends on #337 for travis.

@himdel himdel closed this Apr 7, 2021
@himdel himdel reopened this Apr 7, 2021
@himdel himdel added the backport-4.2 This PR should be backported to stable-4.2 (1.2) label Apr 7, 2021
@himdel himdel merged commit 5355521 into ansible:master Apr 7, 2021
@himdel himdel deleted the npm7 branch April 7, 2021 13:42
@ZitaNemeckova ZitaNemeckova added backport-4.2 This PR should be backported to stable-4.2 (1.2) and removed backport-4.2 This PR should be backported to stable-4.2 (1.2) labels Apr 8, 2021
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 9, 2021
* package.json - ensure npm<7, node 12 or 14

npm 7 comes with node 15 and uses a newer lockfile v2 format,
which is ignored by previous versions of npm

forcing the versions, so that doesn't happen,
and updating the lockfile back to v1

when using a too new version:

    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: 'ansible-hub-ui@0.1.0',
    npm WARN EBADENGINE   required: { node: '>=12, <15', npm: '<7' },
    npm WARN EBADENGINE   current: { node: 'v15.11.0', npm: '7.6.0' }
    npm WARN EBADENGINE }

* Regenerate package-lock.json

v1, and without insights-internal URLs

(cherry picked from commit 5355521)
newswangerd pushed a commit that referenced this pull request Apr 9, 2021
* package.json - ensure npm<7, node 12 or 14

npm 7 comes with node 15 and uses a newer lockfile v2 format,
which is ignored by previous versions of npm

forcing the versions, so that doesn't happen,
and updating the lockfile back to v1

when using a too new version:

    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: 'ansible-hub-ui@0.1.0',
    npm WARN EBADENGINE   required: { node: '>=12, <15', npm: '<7' },
    npm WARN EBADENGINE   current: { node: 'v15.11.0', npm: '7.6.0' }
    npm WARN EBADENGINE }

* Regenerate package-lock.json

v1, and without insights-internal URLs

(cherry picked from commit 5355521)
@himdel himdel added the backported-4.2 This PR has been backported to stable-4.2 (1.2) label Apr 10, 2021
@himdel himdel mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.2 This PR should be backported to stable-4.2 (1.2) backported-4.2 This PR has been backported to stable-4.2 (1.2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants