Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insights: support /preview/ as well as /beta/ #3343

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Feb 20, 2023

On May 1st, console.redhat.com/beta changes to console.redhat.com/preview, with both beta and preview being supported for now.

Updating code and build to fit .. we can test on stage before May.

(see hcc-actions-required mail [ACTION REQUIRED]: Moving from BETA to PREVIEW for context)

@github-actions github-actions bot added the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Feb 20, 2023
@himdel himdel added insights insights-only feature and removed backport-4.6 This PR should be backported to stable-4.6 (2.3) labels Feb 20, 2023
@himdel
Copy link
Collaborator Author

himdel commented Mar 28, 2023

Per slack, appUrl can take an array of both options, deployments stays on /beta/, only ui router needs to accept both

(updated accordingly)

@himdel himdel force-pushed the insights-preview branch from 7b3ed5a to 7e9d34e Compare April 24, 2023 16:16
/preview/ only affects frontend routing, assets stay at /beta/
@himdel himdel force-pushed the insights-preview branch from 62af8db to 4062108 Compare April 24, 2023 16:58
@himdel himdel marked this pull request as ready for review April 24, 2023 16:58
@himdel himdel changed the title [May 2023] Insights: switch /beta/ to /preview/ Insights: switch /beta/ to /preview/ Apr 24, 2023
@himdel himdel changed the title Insights: switch /beta/ to /preview/ Insights: support /preview/ as well as /beta/ Apr 24, 2023
@himdel
Copy link
Collaborator Author

himdel commented Apr 24, 2023

Merging to ensure this works on stage-beta.

@himdel himdel merged commit b1f014f into ansible:master Apr 24, 2023
@himdel himdel deleted the insights-preview branch April 24, 2023 18:57
@himdel
Copy link
Collaborator Author

himdel commented Apr 24, 2023

Works,
loading partners on prod-beta with /preview/ just goes to beta not-found,
loading partners on stage-beta with /preview/ works just fine 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
insights insights-only feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant