Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send my_permissions field when repository/remote is edited (fixes a 400 Bad request) #3506

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Don't send my_permissions field when repository/remote is edited (fixes a 400 Bad request) #3506

merged 1 commit into from
Apr 4, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Apr 4, 2023

Fixes: AAH-2233

delete my_permissions before saving the form.

@himdel
Don't send my_permissions field when repository/remote is edited (fix…
958dfa6 
…es a 400 Bad request)

delete my_permissions before saving

Issue: AAH-2233
@github-actions github-actions bot added the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 4, 2023
@himdel himdel added bug backport-4.7 This PR should be backported to stable-4.7 (2.4) and removed backport-4.6 This PR should be backported to stable-4.6 (2.3) labels Apr 4, 2023
@himdel himdel merged commit ac967a0 into ansible:master Apr 4, 2023
@himdel himdel deleted the fix2233-my-perm branch April 4, 2023 14:06
@patchback
Copy link

patchback bot commented Apr 4, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/ac967a0f5d8e331a195f7a1f942cf405257ba83a/pr-3506

Backported as #3534

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 4, 2023
@himdel @patchback
Don't send my_permissions field when repository/remote is edited (fix…
259cc1e 
…es a 400 Bad request) (#3506)

delete my_permissions before saving

Issue: AAH-2233
(cherry picked from commit ac967a0)
@patchback patchback bot mentioned this pull request Apr 4, 2023
Merged
himdel added a commit that referenced this pull request Apr 4, 2023
@patchback @himdel
Don't send my_permissions field when repository/remote is edited (fix…
5d78ac5 
…es a 400 Bad request) (#3506) (#3534)

delete my_permissions before saving

Issue: AAH-2233
(cherry picked from commit ac967a0)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chr-stian chr-stian chr-stian approved these changes

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himdel @chr-stian