Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make alerts return error messages from API #3542

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Make alerts return error messages from API #3542

merged 1 commit into from
Apr 12, 2023

Conversation

newswangerd
Copy link
Member

Add server messages to error notifications in the UI when the server returns a valid message body:

image

No-Issue

@newswangerd newswangerd requested a review from himdel April 7, 2023 10:15
@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Apr 7, 2023
@newswangerd newswangerd removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 7, 2023
@newswangerd newswangerd mentioned this pull request Apr 7, 2023
Merged
@newswangerd newswangerd merged commit 2239323 into ansible:master Apr 12, 2023
@patchback
Copy link

patchback bot commented Apr 12, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/223932340334513cb457a347e27fe5582f4cbd72/pr-3542

Backported as #3572

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Apr 12, 2023
Merged
patchback bot pushed a commit that referenced this pull request Apr 12, 2023
@newswangerd @patchback
Make alerts return error messages from API (#3542)
642ef57 
No-Issue

(cherry picked from commit 2239323)
himdel pushed a commit that referenced this pull request Apr 12, 2023
@patchback @newswangerd
Make alerts return error messages from API (#3542) (#3572)
3089400 
No-Issue

(cherry picked from commit 2239323)

Co-authored-by: David Newswanger <dnewswan@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newswangerd @himdel