Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enter handling to Group create modal #355

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

ZitaNemeckova
Copy link
Member

Fixes https://issues.redhat.com/browse/AAH-229

Steps to reproduce:

  • login with an account that can create groups
  • navigate to the groups page
  • hit 'create'
  • enter a name for the group - try it with new name as well as a name of an existing group
  • hit the key
  • observe the page reloading, but your new group doesn't exist/seethere's no create request

Before: The form disappears, the page reloads, but no group is created.
After:

  • When filling out the new group form, after filling out a new name of the new group hitting submits the form and the group is created.
  • When filling out the new group form, after filling out a name of an existing group hitting you can see that the name input is invalid with error message.

Verified

This commit was signed with the committer’s verified signature.
newswangerd David Newswanger
@ZitaNemeckova ZitaNemeckova requested a review from himdel April 21, 2021 10:44
@ZitaNemeckova ZitaNemeckova added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) labels Apr 21, 2021
@newswangerd newswangerd merged commit e576cdd into ansible:master Apr 21, 2021
@patchback
Copy link

patchback bot commented Apr 21, 2021

Backport to stable-4.2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.2/e576cdd71f7dadad71629c4c2fc5e6c87861f676/pr-355

Backported as #360

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Apr 21, 2021

Backport to stable-4.3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.3/e576cdd71f7dadad71629c4c2fc5e6c87861f676/pr-355

Backported as #361

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 21, 2021

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Fixes https://issues.redhat.com/browse/AAH-229

(cherry picked from commit e576cdd)
newswangerd pushed a commit that referenced this pull request Apr 21, 2021
Fixes https://issues.redhat.com/browse/AAH-229

(cherry picked from commit e576cdd)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
newswangerd pushed a commit that referenced this pull request Apr 21, 2021
Fixes https://issues.redhat.com/browse/AAH-229

(cherry picked from commit e576cdd)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
@ZitaNemeckova ZitaNemeckova added backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0) labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants