R&R detail - show NotFound instead of spinner when not found #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.6
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3587 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
* NotFound - convert to functional, export also as component * Repos & Remotes - treat empty list on detail query as 404 * PageWithTabs - show NotFound when item fails to load * Show NotFound instead of spinner for nonexistent Repository/Remote detail Issue: AAH-2282 (cherry picked from commit 6fdf151)
himdel
added a commit
that referenced
this pull request
Apr 13, 2023
…3587) * NotFound - convert to functional, export also as component * Repos & Remotes - treat empty list on detail query as 404 * PageWithTabs - show NotFound when item fails to load * Show NotFound instead of spinner for nonexistent Repository/Remote detail Issue: AAH-2282 (cherry picked from commit 6fdf151) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAH-2282
The R&R detail screens load the item using the list API .. so we never get a 404, only an empty list -> handle that.
And handle the "no items, not loading" state by rendering the NotFound component.