Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy roles: fix l10n typo #3570

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Legacy roles: fix l10n typo #3570

merged 1 commit into from
Apr 13, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Apr 11, 2023

Instead of trying to translate "role.github_user logo", these should extract as "{role.github_user} logo"

@himdel himdel added the community comunity mode feature label Apr 11, 2023
@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Apr 11, 2023
@himdel himdel removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 11, 2023
@himdel himdel merged commit c87be1a into ansible:master Apr 13, 2023
@himdel himdel deleted the legacy-l10n branch April 13, 2023 21:22
@patchback
Copy link

patchback bot commented Apr 13, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/c87be1a0f856a8cfd2972db21b83bb852b4036ba/pr-3570

Backported as #3591

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 13, 2023
@himdel @patchback
Legacy roles: fix l10n typo (#3570)
57555c6 
No-Issue

(cherry picked from commit c87be1a)
@patchback patchback bot mentioned this pull request Apr 13, 2023
Merged
himdel added a commit that referenced this pull request Apr 13, 2023
@patchback @himdel
Legacy roles: fix l10n typo (#3570) (#3591)
a860cbf 
No-Issue

(cherry picked from commit c87be1a)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) community comunity mode feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@himdel