Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select collection screen - multi select, repository field, repo filter #3581

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Select collection screen - multi select, repository field, repo filter #3581

merged 4 commits into from
Apr 14, 2023

Conversation

jerabekjiri
Copy link
Contributor

@jerabekjiri jerabekjiri commented Apr 13, 2023 •
edited
Loading

Issue: AAH-2274

  • multi select and repository column:
    Screenshot from 2023-04-13 14-19-51

Screenshot from 2023-04-13 14-18-07

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Apr 13, 2023
@jerabekjiri jerabekjiri removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 13, 2023
@jerabekjiri jerabekjiri requested a review from himdel April 13, 2023 15:00
@himdel
Copy link
Collaborator

himdel commented Apr 13, 2023 •
edited
Loading

The rest looks good 👍
(not needed for 4.7.0, but backport when ready, add fix version 2.4 if we can make it)

@jerabekjiri jerabekjiri merged commit 091fe65 into ansible:master Apr 14, 2023
@patchback
Copy link

patchback bot commented Apr 14, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/091fe652a4a460c01bab5b7ee5d5f9bf8c1166d5/pr-3581

Backported as #3598

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Apr 14, 2023
Merged
patchback bot pushed a commit that referenced this pull request Apr 14, 2023
@jerabekjiri @patchback
Select collection screen - multi select, repository field, repo filter (
b2400b2 
#3581)

* add repo col and filter
* add multi select in select collection screen
* add source repo name to add alert
* fix alert plural translation
Issue: AAH-2274

(cherry picked from commit 091fe65)
himdel pushed a commit that referenced this pull request Apr 14, 2023
@patchback @jerabekjiri
Select collection screen - multi select, repository field, repo filter (
68f6298 
#3581) (#3598)

* add repo col and filter
* add multi select in select collection screen
* add source repo name to add alert
* fix alert plural translation
Issue: AAH-2274

(cherry picked from commit 091fe65)

Co-authored-by: Jiří Jeřábek <Jerabekjirka@email.cz>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel left review comments

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerabekjiri @himdel