Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #3504/bea7ea18 backport][stable-4.7] Approval Modal test #3584

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 13, 2023

This is a backport of PR #3504 as merged into master (bea7ea1).

Requires: ansible/galaxykit#87

Issue: https://issues.redhat.com/browse/AAH-2248

Tests for approval process. Two files - one for testing the repo table in modal - paging, filtering, ordering and selection. Other for approval and rejection tests. Those are both added in new folder, so the tests can run more in parallel (approval tests were very slow even before).

* Approve, Reject and Reapprove

* Finish approval process test, move it to separate folder
No-Issue

* Changes file
Issue: AAH-2248

* Better data-cy selector

(cherry picked from commit bea7ea1)
@patchback patchback bot mentioned this pull request Apr 13, 2023
@app-sre-bot
Copy link

Can one of the admins verify this patch?

@himdel
Copy link
Collaborator

himdel commented Apr 13, 2023

(we'll need to either release a new galaxykit version with galaxykit#87 in, or relax the "stable branches use released versions" convention until then for the new test to pass) EDIT: done (0.14)
(not needed for 4.7.0 release)

@himdel himdel closed this May 29, 2023
@himdel himdel reopened this May 29, 2023
@himdel himdel merged commit c91f9c3 into stable-4.7 May 30, 2023
@himdel himdel deleted the patchback/backports/stable-4.7/bea7ea1860baad3badb39ffd624121b640270bbf/pr-3504 branch May 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants