Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepoSelector - remove Select logic, just show current repo #3596

Merged
merged 1 commit into from
Apr 14, 2023
Merged

RepoSelector - remove Select logic, just show current repo #3596

merged 1 commit into from
Apr 14, 2023
+22 −76

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Apr 14, 2023 •
edited
Loading

Before:
20230414032338

After:
20230414032318

remove the selector logic from repo selector, and make it slightly clearer that this is read only now.

Issue: AAH-2232

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Apr 14, 2023
@himdel himdel requested a review from jerabekjiri April 14, 2023 03:29
@himdel himdel removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 14, 2023
@himdel himdel force-pushed the repo-selector-cleanup branch from a001f81 to 011ee8f Compare April 14, 2023 03:30
@himdel himdel merged commit 4aff395 into ansible:master Apr 14, 2023
@himdel himdel deleted the repo-selector-cleanup branch April 14, 2023 16:07
@patchback
Copy link

patchback bot commented Apr 14, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/4aff3956248f8f8372e7c0faf681de317a01f961/pr-3596

Backported as #3600

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 14, 2023
@himdel @patchback
RepoSelector - remove Select logic, just show current repo (#3596)
19646b5 
Issue: AAH-2232
(cherry picked from commit 4aff395)
@patchback patchback bot mentioned this pull request Apr 14, 2023
Merged
himdel added a commit that referenced this pull request Apr 14, 2023
@patchback @himdel
RepoSelector - remove Select logic, just show current repo (#3596) (#…
dfbdc09 
…3600)

Issue: AAH-2232
(cherry picked from commit 4aff395)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerabekjiri jerabekjiri

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himdel @jerabekjiri