Fix EmptyStateFilter not appearing in Namespace detail when filtering by repo/tags/sign state #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by repo Issue: AAH-2304
github-actions
bot
added
backport-4.6
|
Not related to this PR, but adding more than one tag breaks with |
fixes being unable to add more tags to filter when filtering by 1 tag (it works when 0 tags, falling back to []; works when 2+ tags because it is automatically an array; but fails to add/remove tags when only one is selected)
|
Ah, when 0 or 2+ tags, they get treated as an array of tags, Wrapping in an array :) |
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3604 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
… by repo/tags/sign state (#3597) * Fix EmptyStateFilter not appearing in Namespace detail when filtering by repo Issue: AAH-2304 * compoundFilter: one tag is a string, not an array - convert to array fixes being unable to add more tags to filter when filtering by 1 tag (it works when 0 tags, falling back to []; works when 2+ tags because it is automatically an array; but fails to add/remove tags when only one is selected) (cherry picked from commit 1a08a6b)
himdel
added a commit
that referenced
this pull request
Apr 15, 2023
… by repo/tags/sign state (#3597) (#3604) * Fix EmptyStateFilter not appearing in Namespace detail when filtering by repo Issue: AAH-2304 * compoundFilter: one tag is a string, not an array - convert to array fixes being unable to add more tags to filter when filtering by 1 tag (it works when 0 tags, falling back to []; works when 2+ tags because it is automatically an array; but fails to add/remove tags when only one is selected) (cherry picked from commit 1a08a6b) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2304
Previously
EmptyStateFilterwould only render when no data and filtering by keywords, adding the rest ofCollectionFilterparams.