Fix version modal - load data on pagination #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.6
Follows ansible#3595 the version selector modal still operates under the assumption that collections contains all the versions, not just the first page making the modal query the api on pagination, have a loading spinner, default page size to 10, not 20 to match the loadCollections request No-Issue
himdel
force-pushed
the
version-modal-fix
branch
from
b57dc34 to
87697d2
Compare
|
ty! |
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3653 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Follows #3595 the version selector modal still operates under the assumption that collections contains all the versions, not just the first page making the modal query the api on pagination, have a loading spinner, default page size to 10, not 20 to match the loadCollections request No-Issue (cherry picked from commit 8e99d29)
himdel
added a commit
that referenced
this pull request
Apr 26, 2023
Follows #3595 the version selector modal still operates under the assumption that collections contains all the versions, not just the first page making the modal query the api on pagination, have a loading spinner, default page size to 10, not 20 to match the loadCollections request No-Issue (cherry picked from commit 8e99d29) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #3595,
open a collection detail when the collection has more than 10 versions available.
Open version selector, more versions, go to page 2, 💥
the version selector modal still operates under the assumption that collections contains all the versions, not just the first page
making the modal query the api on pagination, have a loading spinner, default page size to 10, not 20 to match the loadCollections request
Cc @jctanner , thanks for finding this! :)
Before:
After:
