Disable checkbox for adding collection if collection is already assigned to repository

[jerabekjiri]

Issue: AAH-2323

User experience improvement, but for performance cost. It could be a little inefficient to fetch collections from the collection versions list again and match them with modal collection versions. So I think we need to think this through if we want to include this. :)

before:

after:

[himdel]

Looks like a nice improvement 👍, but yeah, you're right the logic can get a bit ..complex :)

This will only work if the "collection version + repo" entry is in the same page of results when filtering by repo and when not, right?

But .. then again.. we're already showing "repository" in the modal list ...so is there a need for the extra query? Or could we just check that repository is not the current repository when the version matches?

(Though, if collection C version V is already in staging and validated, we should probably be greying out both entries, since that same collection version is already in our repo.)

((I wonder if we could add this as an api filter, or if it would make sense to fire a specific query to check for each C-V pair ...))

[jerabekjiri]

This will only work if the "collection version + repo" entry is in the same page of results when filtering by repo and when not, right?

Yep, that's too bad thanks to pagination, this will only work sometimes...

But .. then again.. we're already showing "repository" in the modal list ...so is there a need for the extra query? Or could we just check that repository is not the current repository when the version matches?

make sense, checking if repository matches should be sufficient enough for now and the cleanest solution, more improvements should be made on API (remove duplicates or c-v pair match)

[patchback]

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/50f33a3a201d3240365d11203edb9009a32cc664/pr-3657

Backported as #3733

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.