Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify and fix missing permissions on container repo form. #370

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Clarify and fix missing permissions on container repo form. #370

merged 1 commit into from
Apr 23, 2021
+20 −8

Conversation

newswangerd
Copy link
Member

  • Update exposed namespace permissions
  • Wordsmith descriptions of permissions
  • Add a note about permissions being assigned to namespaces, not repos on the repo edit form.
    Screen Shot 2021-04-22 at 4 04 05 PM

@newswangerd
Clarify and fix missing permissions on container repo form.

Verified

This commit was signed with the committer’s verified signature.
newswangerd David Newswanger
GPG key ID: 7001043C9886A543
Verified
Learn about vigilant mode
9fb4f1e
@newswangerd newswangerd added the backport-4.3 This PR should be backported to stable-4.3 (2.0) label Apr 22, 2021
@newswangerd newswangerd requested a review from himdel April 22, 2021 20:22
himdel
himdel approved these changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works for me :)

@newswangerd newswangerd merged commit 54445f1 into ansible:master Apr 23, 2021
@patchback
Copy link

patchback bot commented Apr 23, 2021 •
edited
Loading

Backport to stable-4.3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.3/54445f16c07b133a82e243c58c1c4d977bff3915/pr-370

Backported as #371

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 23, 2021
@newswangerd
Clarify and fix missing permissions on container repo form. (#370)
085c4c6 
(cherry picked from commit 54445f1)
@patchback patchback bot mentioned this pull request Apr 23, 2021
Merged
newswangerd added a commit that referenced this pull request Apr 23, 2021
@patchback @newswangerd
Clarify and fix missing permissions on container repo form. (#370) (#371

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
69c3919 
)

(cherry picked from commit 54445f1)

Co-authored-by: David Newswanger <dnewswan@redhat.com>
@ZitaNemeckova ZitaNemeckova added the backported-4.3 This PR has been backported to stable-4.3 (2.0) label May 6, 2021
@himdel himdel mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel

@ZitaNemeckova ZitaNemeckova

Assignees
No one assigned
Labels
backport-4.3 This PR should be backported to stable-4.3 (2.0) backported-4.3 This PR has been backported to stable-4.3 (2.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@newswangerd @himdel @ZitaNemeckova