Synclist deprecation #3708

ShaiahWren · 2023-05-09T17:58:19Z

This pr addresses some of the issues in https://issues.redhat.com/browse/AAH-2335.

awcrosby · 2023-05-11T19:31:38Z

src/containers/token/token-insights.tsx

              </Trans>
            </p>
-            <ClipboardCopy isReadOnly>{getRepoUrl('published')}</ClipboardCopy>
+            <ClipboardCopy isReadOnly>{`${getRepoUrl(


does this change what is displayed (an therefore copied in the clipboard) or just change what is copied?

it changes both :)

src/containers/token/token-insights.tsx

src/loaders/insights/loader.tsx

awcrosby · 2023-05-11T19:37:03Z

src/loaders/insights/loader.tsx

@@ -62,7 +62,7 @@ const App = (_props) => {
      <Alert
        isInline
        variant='info'
-        title={t`The Automation Hub sync toggle is now only supported in AAP 2.0. Previous versions of AAP will continue automatically syncing all collections.`}
+        title={t`Use the Repositories page to sync collections curated by your organization to the Red Hat Certified repository in your private Automation Hub. Users with the correct permissions can use the sync toggles on the Collections page to control which collections are added to their organization's sync repository.`}


The suggestion for "Use the Repositories page..." is for the text located here:

ansible-hub-ui/src/containers/token/token-insights.tsx

Lines 99 to 108 in e39d055

Use the{' '}

<Link to={formatPath(Paths.ansibleRepositories)}>

Repositories

</Link>{' '}

page to sync collections curated by your organization to the Red

Hat Certified repository in your private Automation Hub. Users

with the correct permissions can use the sync toggles on the{' '}

<Link to={formatPath(Paths.collections)}>Collections</Link> page

to control which collections are added to their

organization's sync repository.

himdel · 2023-05-23T18:35:53Z

src/containers/token/token-insights.tsx

-            <ClipboardCopy isReadOnly>{getRepoUrl('published')}</ClipboardCopy>
+            <ClipboardCopy isReadOnly>{`${getRepoUrl(
+              'published',
+            )}content/published`}</ClipboardCopy>


This bit will need a rebase, there's a conflict now. (getRepoUrl vs getRepoURL)

But .. this may be the wrong place to add extra bits ... the getRepoURL function deliberately skips content/published when dealing with the published repo .. if there is a situation when it shouldn't skip it, it should be a param.

(Is there a reason to use .../content/published or will this work with the default?)

https://issues.redhat.com/browse/AAH-2335 This might help - "Change the displayed URL from https://console.stage.redhat.com/api/automation-hub/ to https://console.stage.redhat.com/api/automation-hub/content/published/ so it is clear they are getting content under "published" repo since now there are 2 repos to choose from."

Issue: AAH-2335

reverts ansible#4198 / reapplies ansible#3708, ansible#3346, ansible#3893 (AAP 2.3 is EOL, no need to support it on cloud)

reverts ansible#4198 / reapplies ansible#3708, ansible#3346, ansible#3893 (AAP 2.3 is EOL, no need to support it on cloud) keep 2.4 synclist deprecation notice

* Update tooling for 4.6 eol No-Issue * Token insights - remove MyDistribution query, drop synclist url reverts #4198 / reapplies #3708, #3346, #3893 (AAP 2.3 is EOL, no need to support it on cloud) keep 2.4 synclist deprecation notice

ShaiahWren requested a review from awcrosby May 9, 2023 17:58

github-actions bot added backport-4.6 backport-4.7 labels May 9, 2023

ShaiahWren marked this pull request as draft May 9, 2023 17:59

ShaiahWren requested a review from himdel May 9, 2023 18:09

awcrosby reviewed May 11, 2023

View reviewed changes

src/containers/token/token-insights.tsx Outdated Show resolved Hide resolved

awcrosby reviewed May 11, 2023

View reviewed changes

src/loaders/insights/loader.tsx Outdated Show resolved Hide resolved

awcrosby reviewed May 11, 2023

View reviewed changes

ShaiahWren force-pushed the synclist-deprecation branch 6 times, most recently from 48301a6 to 1ff3421 Compare May 16, 2023 18:24

himdel added insights and removed backport-4.6 backport-4.7 labels May 18, 2023

ShaiahWren marked this pull request as ready for review May 19, 2023 14:58

ShaiahWren requested a review from awcrosby May 22, 2023 15:04

awcrosby approved these changes May 23, 2023

View reviewed changes

himdel reviewed May 23, 2023

View reviewed changes

ShaiahWren added 7 commits May 24, 2023 10:25

change message connect to hub > server url message

684c144

Issue: AAH-2335

add to changelog

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

145a94d

Issue: AAH-2335

reword header message

09547b0

Issue: AAH-2335

add published/ suffix to server url

f8c2e1a

Issue: AAH-2335

remove alert

4a78623

Issue: AAH-2335

add note about synclist documentation

bd71120

Issue: AAH-2335

use param to expose /content/published

3bd81ad

Issue: AAH-2335

ShaiahWren force-pushed the synclist-deprecation branch from 1ff3421 to 3bd81ad Compare May 24, 2023 17:39

ShaiahWren requested a review from himdel May 24, 2023 17:43

himdel approved these changes May 24, 2023

View reviewed changes

ShaiahWren merged commit 0e31a92 into ansible:master May 24, 2023

ShaiahWren deleted the synclist-deprecation branch May 24, 2023 18:42

himdel mentioned this pull request Sep 9, 2023

Token insights - restore MyDistribution query, show separate synclist url #4198

Merged

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Jan 9, 2024

Token insights - remove MyDistribution query, drop synclist url

246e7a6

reverts ansible#4198 / reapplies ansible#3708, ansible#3346, ansible#3893 (AAP 2.3 is EOL, no need to support it on cloud)

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Jan 12, 2024

Token insights - remove MyDistribution query, drop synclist url

d053c5a

reverts ansible#4198 / reapplies ansible#3708, ansible#3346, ansible#3893 (AAP 2.3 is EOL, no need to support it on cloud)

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Feb 9, 2024

Token insights - remove MyDistribution query, drop synclist url

cb32fe7

reverts ansible#4198 / reapplies ansible#3708, ansible#3346, ansible#3893 (AAP 2.3 is EOL, no need to support it on cloud)

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Feb 9, 2024

Token insights - remove MyDistribution query, drop synclist url

204aa2c

reverts ansible#4198 / reapplies ansible#3708, ansible#3346, ansible#3893 (AAP 2.3 is EOL, no need to support it on cloud)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Synclist deprecation #3708

Synclist deprecation #3708

ShaiahWren commented May 9, 2023 •

edited

Loading

awcrosby May 11, 2023

ShaiahWren May 16, 2023

awcrosby May 11, 2023 •

edited

Loading

himdel May 23, 2023 •

edited

Loading

ShaiahWren May 24, 2023 •

edited

Loading

	Use the{' '}
	<Link to={formatPath(Paths.ansibleRepositories)}>
	Repositories
	</Link>{' '}
	page to sync collections curated by your organization to the Red
	Hat Certified repository in your private Automation Hub. Users
	with the correct permissions can use the sync toggles on the{' '}
	<Link to={formatPath(Paths.collections)}>Collections</Link> page
	to control which collections are added to their
	organization's sync repository.

Synclist deprecation #3708

Synclist deprecation #3708

Conversation

ShaiahWren commented May 9, 2023 • edited Loading

awcrosby May 11, 2023

Choose a reason for hiding this comment

ShaiahWren May 16, 2023

Choose a reason for hiding this comment

awcrosby May 11, 2023 • edited Loading

Choose a reason for hiding this comment

himdel May 23, 2023 • edited Loading

Choose a reason for hiding this comment

ShaiahWren May 24, 2023 • edited Loading

Choose a reason for hiding this comment

ShaiahWren commented May 9, 2023 •

edited

Loading

awcrosby May 11, 2023 •

edited

Loading

himdel May 23, 2023 •

edited

Loading

ShaiahWren May 24, 2023 •

edited

Loading