Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for repositories #3714

Merged
merged 7 commits into from
May 15, 2023

Conversation

MilanPospisil
Copy link
Contributor

@MilanPospisil MilanPospisil commented May 12, 2023

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels May 12, 2023
@MilanPospisil MilanPospisil marked this pull request as ready for review May 15, 2023 12:24
cy.get('[data-cy="Page-AnsibleRepositoryEdit"]');
});

it.skip('tests CLI config', () => {
Copy link
Collaborator

@himdel himdel May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the skip?

EDIT: ah, Write permission denied. because js doesn't have the clipboard permission in headless mode .. looks like something like https://github.com/kamranayub/cypress-browser-permissions#chrome--edge-chromium might help (but we can also address this separately)

=> #3756

@himdel himdel removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label May 15, 2023
@MilanPospisil MilanPospisil merged commit ba120d9 into ansible:master May 15, 2023
@patchback
Copy link

patchback bot commented May 15, 2023

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/ba120d9c4a7eacd5a6d3faad68e8f1569573b9be/pr-3714

Backported as #3734

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 15, 2023
* Data-cy

* Add tests

* Changes
Issue: AAH-2245

* Skip failing test

* With and without remote

* Versions and revert

* PR Checks

(cherry picked from commit ba120d9)
himdel added a commit that referenced this pull request May 30, 2023
* Create tests for repositories (#3714)

* Data-cy

* Add tests

* Changes
Issue: AAH-2245

* Skip failing test

* With and without remote

* Versions and revert

* PR Checks

(cherry picked from commit ba120d9)

* Repository tests - unskip clipboard test, grant permissions

the repo test was skipped because in headless chrome, copying to clipboard fails with 'Write permission denied.'

grant the permission in before, so the test can pass

(this only works for chrome/chromium)

No-Issue

* Repository tests: create distribution for one repo, copy cli fails otherwise

No-Issue

(cherry picked from commit 12479d9)

---------

Co-authored-by: MilanPospisil <arkanus@seznam.cz>
Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label May 30, 2023
@himdel himdel added the tests tests PR label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) tests tests PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants