-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection documentation: do not wrongly interpret plugins/modules whose name starts with _
as deprecated
#3715
Conversation
9aae340
to
07a9a75
Compare
…ose name starts with `_` as deprecated. No-Issue Signed-off-by: Felix Fontein <felix@fontein.de>
Not sure whether the changelog fragment's filename is OK like this; I took the PR's # since I'm not aware of a AH Jira issue. |
Good catch 👍 AAH 4.6 / AAP 2.3 is core 2.14, so we'll only want this in 4.7+, right? |
They weren't really deprecated in ansible-core 2.14 either, it was just that valide-modules somehow assumed so and that ansible-doc showed them as deprecated and at the same time printed their name wrong (it removed the underscore). Not backporting to 4.6 is probably saving some discussions so ... it's probably better :) |
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #3732 🤖 @patchback |
@himdel thanks for reviewing and merging! |
Any time :) |
I'm not sure whether an issue exists for this I can reference. I spotted this while working on #3607 and noticing that a plugin in a collection I was uploading for testing was wrongly marked as deprecated.
In ansible-core itself, an underscore was interpreted this way also in ansible-doc and the validate-modules sanity test (but nowhere else), but that was changed for 2.15.
Ref: ansible/ansible#79362