waitForTask: switch from polling every 5s to an incremental 2s, 3s, 4.5s, 6.75s, ~10s... progression #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.6
….5s, 6.75s, ~10s... progression
optimizes for tasks finishing early by trying more often in the beginning,
but also ends up waiting longer for long-running tasks
this takes the default waitForTask max wait from $`5 * 10 = 50s`$,
to $` \displaystyle\sum_{n=1}^{10} 2 * 1.5^n \approx 226s `$.
Related to AAH-2347
No-Issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes for tasks finishing early by trying more often in the beginning,
but also ends up waiting longer for long-running tasks
this takes the default waitForTask max wait from$5 * 10 = 50s$ ,$\displaystyle\sum_{n=1}^{10} 2 * 1.5^n \approx 226s$ .
to
Related to AAH-2347 - we just need to wait a bit longer for long-running tasks.