-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete collection all or single repo #3759
Merged
MilanPospisil
merged 36 commits into
ansible:master
from
MilanPospisil:deleteCollectionAllOrSingleRepo
Jun 13, 2023
Merged
Delete collection all or single repo #3759
MilanPospisil
merged 36 commits into
ansible:master
from
MilanPospisil:deleteCollectionAllOrSingleRepo
Jun 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42e20da
to
42b285b
Compare
himdel
reviewed
May 30, 2023
120be6a
to
a3fd34a
Compare
13be395
to
a1820b9
Compare
himdel
reviewed
Jun 10, 2023
We should check the |
himdel
reviewed
Jun 12, 2023
Looks good, just the linter fix please :) |
589c15f
to
72b7279
Compare
himdel
approved these changes
Jun 13, 2023
Backport to stable-4.7: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c09590f on top of patchback/backports/stable-4.7/c09590f3cc5e0b787a9739d7646254e78316349b/pr-3759 Backporting merged PR #3759 into master
🤖 @patchback |
himdel
pushed a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Jun 28, 2023
* Menu option to delete collection from all/repo * Delete collection operation * Collection version menu option * Delete collection version * Test changes * Test changes repairs * Test for deletion collection from repo * Tests fix * WIP * Clear of orphans * Clear collections only * Better cleanup * Remove cleanup * Delete version from repo test * Handle translations * Issue Issue: AAH-2261 * PR Checks * Repair selector for insights * Fix collection test for insights * Fix collection test for insights2 * Finally really fix insights tests :) * Switch contains and not contains * Disable new test for insights * Do not delete repos * WIP * Correct tests * Collection Tests back to normal + new repo test * Fix collection test * Clear the mess done by previous commits in deleteAllCollections * Make deleteNamespacesAndCollections clearer * Move test to approvals * Fix copy collection version test * Disable removal from repo for insights * Better translations in delete modal * Change condition to display delete from repo to feature flag instead of insights mode * Add deleteFromRepo string type (cherry picked from commit c09590f)
himdel
added a commit
that referenced
this pull request
Jul 3, 2023
* Menu option to delete collection from all/repo * Delete collection operation * Collection version menu option * Delete collection version * Test changes * Test changes repairs * Test for deletion collection from repo * Tests fix * WIP * Clear of orphans * Clear collections only * Better cleanup * Remove cleanup * Delete version from repo test * Handle translations * Issue Issue: AAH-2261 * PR Checks * Repair selector for insights * Fix collection test for insights * Fix collection test for insights2 * Finally really fix insights tests :) * Switch contains and not contains * Disable new test for insights * Do not delete repos * WIP * Correct tests * Collection Tests back to normal + new repo test * Fix collection test * Clear the mess done by previous commits in deleteAllCollections * Make deleteNamespacesAndCollections clearer * Move test to approvals * Fix copy collection version test * Disable removal from repo for insights * Better translations in delete modal * Change condition to display delete from repo to feature flag instead of insights mode * Add deleteFromRepo string type (cherry picked from commit c09590f) Co-authored-by: MilanPospisil <arkanus@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backported-4.7
This PR has been backported to stable-4.7 (2.4)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/AAH-2261
Depends on ansible/galaxykit#93
This PR Adds:
Delete collection from repository - this is added into all collection menus (collection list, namespace collection list and collection detail).
Delete collection version from repository - this is added into collection detail only.
Both deletes from repository are only visible in standalone, since Insights mode does not have any repo management, this operation is meaningless.
Added tests for those operations.
existing "should copy collection version to validated repository" test is fixed
Delete entire collection menu item name slightly renamed from "Delete entire collection" to "Delete entire collection from system" to better distinguish from "Delete collection from repository"
deleteNamespacesAndCollections test command slightly changed. Now it does not removes orphan collections (otherwise it fails on them) and does not removes namespaces that has orphan collections. Also task wait all is used instead of more complicated waiting.